CIsco CSR VPNaaS service & device driver cleanup

Bug #1288387 reported by Paul Michali
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Paul Michali

Bug Description

Post blueprint vpnaas-cisco, there were minor review comments that this bug will address.

- LOG.error -> LOG.exception in _request() of device driver
- assertEqual(0, ...call_count) -> AssertFalse(...called) for two UTs in device driver

Revision history for this message
Paul Michali (pcm) wrote :

If httmock package is added to test-requirements as part of 75296 review, we can enable REST API unit tests for device driver.

Changed in neutron:
assignee: nobody → Paul Michali (pcm)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/80062

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/80062
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=7f096512bbccee92da24e8f408f1d7f4f100cc95
Submitter: Jenkins
Branch: master

commit 7f096512bbccee92da24e8f408f1d7f4f100cc95
Author: Paul Michali <email address hidden>
Date: Wed Mar 12 14:04:30 2014 +0000

    Cisco VPN device driver post-merge cleanup

    During review for I-3 there were some minor comments regarding log
    level on message and asserts for mock calls.

    In addition, some debug logging enhancements were made between the
    service and device driver to better indicate the source of the
    shared "vpnservice_updated" RPC.

    Lastly, unit tests were updated, based on a newer Cisco CSR image,
    which had REST API fixes and behavior changes.

    Change-Id: I22277462270df0b2cd642ec576e8652c9df146b5
    Closes-bug: 1288387

Changed in neutron:
status: In Progress → Fix Committed
Akihiro Motoki (amotoki)
Changed in neutron:
milestone: none → icehouse-rc1
importance: Undecided → Low
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: icehouse-rc1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.