Change parameters of add_timestamp in ComputeDriverCPUMonitor class

Bug #1288281 reported by Fengqian
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Fengqian

Bug Description

'cls' may mislead developpers that this Decorator return a classmethod. Change parameter 'cls' to 'self' in wrapper.

Fengqian (fengqian-gao)
Changed in nova:
assignee: nobody → Fengqian (fengqian-gao)
Fengqian (fengqian-gao)
Changed in nova:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/73139
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=b69584a523f41f8171805e22ac6a0b29172e832e
Submitter: Jenkins
Branch: master

commit b69584a523f41f8171805e22ac6a0b29172e832e
Author: Fengqian Gao <email address hidden>
Date: Wed Mar 5 13:43:26 2014 +0800

    Change parameters of add_timestamp in ComputeDriverCPUMonitor class

    Change parameter 'cls' to 'self' in wrapper. 'cls' may mislead developpers
    that this decorator returns a classmethod. Use functools.wraps to follow
    the common pattern of decorator in nova.

    closes-bug: #1288281

    Change-Id: I6acbcba7297607dc6d07e8668ad07e6ca81d4456

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → juno-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.