Adding panel group to panel config results to Other panel group

Bug #1287981 reported by Lin Hua Cheng
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Lin Hua Cheng

Bug Description

Using the pluggable panel config to add panel groups result to the panel group being added to being displayed in
“Other” group, and getting message in the log saying, “Only Panel classes or subclasses may be registered.”

Changed in horizon:
assignee: nobody → Lin Hua Cheng (lin-hua-cheng)
Revision history for this message
Lin Hua Cheng (lin-hua-cheng) wrote :

A possible solution is to add a support for deployer to create a empty panel group through the configuration.

Sample ADD PANEL GROUP config:
PANEL_GROUP = ‘plugin_panel_group’
PANEL_GROUP_NAME = _(“Plugin Panel Group”)
PANEL_GROUP_DASHBOARD = “admin"

This will just create a panel group placeholder. After the panel group is created, the existing mechanism for adding panels to panel group could be re-use.

Sample ADD PANEL config:
# The name of the panel to be added to HORIZON_CONFIG. Required.
PANEL = 'plugin_panel'
# The name of the dashboard the PANEL associated with. Required.
PANEL_DASHBOARD = 'admin'
# The name of the panel group the PANEL is associated with.
PANEL_GROUP = 'admin'

# Python panel class of the PANEL to be added.
ADD_PANEL = \
    'openstack_dashboard.test.test_panels.plugin_panel.panel.PluginPanel'

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/80765

Changed in horizon:
status: New → In Progress
Changed in horizon:
milestone: none → icehouse-rc1
David Lyle (david-lyle)
Changed in horizon:
importance: Undecided → Medium
Changed in horizon:
assignee: Lin Hua Cheng (lin-hua-cheng) → Akihiro Motoki (amotoki)
Akihiro Motoki (amotoki)
Changed in horizon:
assignee: Akihiro Motoki (amotoki) → Lin Hua Cheng (lin-hua-cheng)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/80765
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=e1080cbe0521a1359220dfa258759d1528868eca
Submitter: Jenkins
Branch: master

commit e1080cbe0521a1359220dfa258759d1528868eca
Author: lin-hua-cheng <email address hidden>
Date: Sat Mar 15 00:50:18 2014 -0700

    Plugin-based panel group configuration

    Panels can be added through plugin configuration, but it is broken
    if the user can only use existing panel groups. This adds the
    capability to create an empty panel group that can be used by panel
    configuration to add itself to the group.

    Change-Id: I28d6072fc05b3a4ef5a41cd68337a7864c560525
    Closes-Bug: #1287981

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: icehouse-rc1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.