EMC VNX Direct Driver needs to be cleaned up
Bug #1287944 reported by
Xing Yang
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Cinder |
Fix Released
|
Medium
|
Xing Yang |
Bug Description
There are quite a few review comments on the EMC VNX Direct Driver:
https:/
These issues need to be addressed right after the code is merged.
Changed in cinder: | |
assignee: | nobody → Xing Yang (xing-yang) |
Changed in cinder: | |
importance: | Undecided → Medium |
milestone: | none → icehouse-rc1 |
Changed in cinder: | |
status: | New → In Progress |
Changed in cinder: | |
status: | Invalid → In Progress |
Changed in cinder: | |
status: | In Progress → Fix Committed |
Changed in cinder: | |
status: | Fix Committed → Fix Released |
Changed in cinder: | |
milestone: | icehouse-rc1 → 2014.1 |
To post a comment you must log in.
Umm... this seems really wrong to me. First if the patch wasn't ready it shouldn't have been merged, it's either ready or it's not. Granted if it's nit picky things that don't effect the functionality of the patch it's not so bad to land it and work on it later.
But there's been this weird trend started lately of creating these "generic catch-all bugs", like "fix cert test issues" which is complete which does us no good whatsoever for trackign info and defeats the purpose of bug tracking. This is another example of useless non-informational bugs ("alot of review comments")??
If you need to file a bug, file a bug with real bug information. If you have cleanup work to do in the driver submit a patch with that cleanup work and document what you're doing. We can make an exception for a merge in RC for things like drivers if we need to and if the changes are actually important.
I'm not even remotely concerned about spelling errors or comment forwarding at this point, any of those things should have been fixed in the first place.