SmartScopesClient - a missing attribute disables all remote scopes

[Paweł Stołowski]

The main loop in SmartScopesClient::get_remote_scopes() that parses remote-scopes result stops processing if a child node of a scope is missing one of the required attributes (or parsing fails for whatever reason). This effectively disables all scopes that hasn't been processed yet.

There are three problems that I see there:

- this "break" statement breaks main loop:

 if (!child_node->has_node("id") || !child_node->has_node("name") ||
                !child_node->has_node("description") || !child_node->has_node("author") ||
                !child_node->has_node("base_url"))
            {
                break;
            }

- no error/warning if a mandatory attribute is missing.

- the try..catch blocks surrounds entire loop (we should be handling exceptions inside the loop so that we can process as many remote scopes as possible).

[Michi Henning (michihenning)]

Thanks for that Pawel!

[Michi Henning (michihenning)]

Could was also please add a test for this? We should test for presence and absence of both mandatory and optional attributes and check that subsequent scopes are still processed correctly.

We should also have tests for any non-trivial attributes, such as URLs. If they don't parse correctly, for example, we need to make sure that we don't abort processing of subsequent entries just because something is wrong with one attribute for one scope.

[PS Jenkins bot (ps-jenkins)]

Fix committed into lp:unity-scopes-api/devel at revision 253, scheduled for release in unity-scopes-api, milestone Unknown