LVM backed images unnecessarily mounted to block devices

Bug #1287754 reported by Andrew Melton
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Thomas Maddox

Bug Description

When using the libvirt drivers support for LVM backed images, the the LVM device is mounted to either a loopback or nbd device before finally being mounted to the rootfs directory for the instance. This is unnecessary because the image is already exposed as a block drive by LVM/device mapper. Thus, the LVM device can be mounted directly to the rootfs of the instance.

Tags: libvirt lxc
Changed in nova:
status: New → In Progress
Tracy Jones (tjones-i)
Changed in nova:
status: In Progress → Triaged
Changed in nova:
assignee: nobody → Andrew Melton (andrew-melton)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/130163

Changed in nova:
assignee: Andrew Melton (andrew-melton) → Rick Harris (rconradharris)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (master)

Change abandoned by Andrew Melton (<email address hidden>) on branch: master
Review: https://review.openstack.org/106405

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Rick Harris (<email address hidden>) on branch: master
Review: https://review.openstack.org/130163

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote :

All 3 reviews are abandoned, removing "In Progress" and assignee

Changed in nova:
assignee: Rick Harris (rconradharris) → nobody
status: In Progress → Confirmed
tags: added: libvirt
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/215311

Changed in nova:
assignee: nobody → Andrew Melton (andrew-melton)
status: Confirmed → In Progress
Changed in nova:
assignee: Andrew Melton (andrew-melton) → John Garbutt (johngarbutt)
Changed in nova:
assignee: John Garbutt (johngarbutt) → Andrew Melton (andrew-melton)
importance: Undecided → Medium
tags: added: lxc
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/215310
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=faeae32a7e5b2048aacb05995b294e9665d78b8e
Submitter: Jenkins
Branch: master

commit faeae32a7e5b2048aacb05995b294e9665d78b8e
Author: Andrew Melton <email address hidden>
Date: Thu Aug 20 11:18:33 2015 -0700

    libvirt: refactor _create_domain_setup_lxc to use Image.get_model

    Instead of trying to figure out what the proper ImageModel is for
    the instance's image, just use the get_model function. The resulting
    ImageModel will actually represent the proper ImageModel for the
    instance, and downstream mounting functions will be able to make
    intelligent decisions on how to mount the instance's disks.

    It is not possible to use get_model for an instance booted from volume,
    but we can still use LocalBlockImage in it's case because it is
    simply exposed as a block device.

    Partial-Bug: #1287754
    Change-Id: I0f4456731c9d6f64affbf6924f4a7a4c34df4fd1

Changed in nova:
assignee: Andrew Melton (andrew-melton) → Thomas Maddox (thomas-maddox)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/215311
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=0e16afa588954d494165368a9eb331421c0bdcd6
Submitter: Jenkins
Branch: master

commit 0e16afa588954d494165368a9eb331421c0bdcd6
Author: Andrew Melton <email address hidden>
Date: Thu Aug 20 12:50:13 2015 -0700

    virt: allow for direct mounting of LocalBlockImages

    Block backed images, are already presented as block devices, so
    LocalBlockImages can be mounted directly instead of being linked
    with loopback or nbd to another block device.

    Change-Id: I5aae1e293832f7cff7bc00d793bcc86ededf5eec
    Closes-bug: #1287754

Changed in nova:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.