The rescue API should handle NotImplementedError

Bug #1287367 reported by Matt Riedemann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Leandro Ignacio Costantino

Bug Description

There are several nova virt drivers that don't implement the rescue API, but the os compute API doesn't handle NotImplementedError, it returns a 400 instead of a 501.

https://wiki.openstack.org/wiki/HypervisorSupportMatrix

The API could be tightened up a bit to return a 501 instead like how the pause admin action is handling NotImplementedError.

Revision history for this message
Matt Riedemann (mriedem) wrote :

The 4th bullet here should come into play when changing the error code for the API:

https://wiki.openstack.org/wiki/APIChangeGuidelines#Generally_Considered_OK

"Changing an error response code to be more accurate"

Changed in nova:
importance: Undecided → Low
tags: added: low-hanging-fruit
Matt Riedemann (mriedem)
Changed in nova:
status: New → Triaged
Changed in nova:
assignee: nobody → Leandro Ignacio Costantino (leandro-i-costantino)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/77736

Changed in nova:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/77736
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=f3f46b532c528c31fbcdc0d18b18105c42a0d74c
Submitter: Jenkins
Branch: master

commit f3f46b532c528c31fbcdc0d18b18105c42a0d74c
Author: Leandro I. Costantino <email address hidden>
Date: Mon Mar 3 21:09:52 2014 -0300

    Rescue API handle NotImplementedError

    There are several nova virt drivers that don't implement the rescue API,
    but the os compute API doesn't handle NotImplementedError,
    it returns a 400 instead of a 501.

    The patch add the proper logic to return a 501 instead.

    Change-Id: Ia649c4dadd50985efed631ce8f3e4b212646766e
    Closes-Bug: #1287367

Changed in nova:
status: In Progress → Fix Committed
Changed in nova:
milestone: none → icehouse-rc1
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: icehouse-rc1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.