VMware: vmdk driver ignoring vmdk_type extra_spec property while copying image with vmware_disktype=thin/preallocated

[Vipin Balachandran]

The volume's vmdk_type extra_spec property is ignored while copying image with vmware_disktype=thin/preallocated to a volume. The image should be downloaded and converted to appropriate type based on vmdk_type.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/98057

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/98057
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=f9402ffe9fbb1ad00fa283a5bf114dc70d2de23f
Submitter: Jenkins
Branch: master

commit f9402ffe9fbb1ad00fa283a5bf114dc70d2de23f
Author: Vipin Balachandran <email address hidden>
Date: Thu Jun 5 12:25:53 2014 +0530

    VMware: Optional create backing parameters

    The current create backing methods do not support specifying an adapter
    type for the backing VM. These methods always create a backing VM with
    a single disk and LSI logic adapter. This change adds optional parameters
    to create backing methods so that a backing VM can be created without a
    disk or with a specific adapter type.

    Partial-Bug: #1284284
    Partial-Bug: #1287185
    Partial-Bug: #1287176
    Change-Id: Ifff64eb2be4af1c4218e810366e25dbecdc5847f

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/106038

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/106113

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/106317

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/106334

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/106038
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=97fbe770bc4dc97218e170103bfe16a1ad632976
Submitter: Jenkins
Branch: master

commit 97fbe770bc4dc97218e170103bfe16a1ad632976
Author: Vipin Balachandran <email address hidden>
Date: Sun Jun 29 18:57:00 2014 +0530

    VMware:Support for create disk and disk descriptor

    This change adds utility methods for creating a virtual disk and virtual
    disk descriptor. Currently volume creation from preallocated image doesn't
    honour the disk type in the volume extra spec and adapter type in the image
    meta-data. The workflow to address these issues require support for the
    above mentioned methods.

    Change-Id: If8ec1fd6c60d26552e5fb58b8bb16a8cc87d9d28
    Partial-Bug: #1284284
    Partial-Bug: #1287185

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/106113
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=15a93312641bb6121d20c7749481104a1ab34bd0
Submitter: Jenkins
Branch: master

commit 15a93312641bb6121d20c7749481104a1ab34bd0
Author: Vipin Balachandran <email address hidden>
Date: Sun Jun 29 19:00:04 2014 +0530

    VMware:Support for attaching disk to backing

    This change adds support for attaching a virtual disk to an existing
    backing VM. Currently volume creation from preallocated/sparse image doesn't
    honour the disk type in the volume extra spec and adapter type in the image
    meta-data. The workflow to address these issues requires the above mentioned
    method. This change also sets the disk size of backing to at least 1MB which
    is the minimum required by VIM APIs.

    Closes-Bug: #1340315
    Partial-Bug: #1284284
    Partial-Bug: #1287185
    Partial-Bug: #1287176

    Change-Id: Icdb1f26d5c8eaa42408a14c57c7394d96dda078f

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/106317
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=5f24034a45b97ef023df4517e66c7e8191ef2c6d
Submitter: Jenkins
Branch: master

commit 5f24034a45b97ef023df4517e66c7e8191ef2c6d
Author: Vipin Balachandran <email address hidden>
Date: Thu Jul 10 12:25:49 2014 +0530

    VMware:Disk type conversion during clone backing

    This patch adds support for converting virtual disk provisioning
    type during clone backing operation. Currently volume creation from
    preallocated/sparse image doesn't honour the disk type property in
    the volume extra spec. The workflow to address this issue requires
    disk provisioning type conversion during clone.

    Partial-Bug: #1287176
    Partial-Bug: #1287185

    Change-Id: Ie493768445b838d3e9447edb76d9845e972bc7c3

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/106334
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=5eac161aa81a68e7cc4adb92798f6c3e849da81c
Submitter: Jenkins
Branch: master

commit 5eac161aa81a68e7cc4adb92798f6c3e849da81c
Author: Vipin Balachandran <email address hidden>
Date: Sun Jun 29 19:02:20 2014 +0530

    VMware: Volume from non-streamOptimized image

    Volume creation from non-streamOptimized images (preallocated/thin/sparse)
    has following problems:

    1) Sparse vmdk image is not converted to appropriate virtual disk type
       suitable for attaching to a nova instance.
    2) The adapter type in image meta-data is ignored while creating volumes.
    3) The vmware:vmdk_type extra_spec property is ignored.
    4) Virtual disk extent operation is called with a wrong parameter which
       might result in unwanted disk provisioning type conversion.

    This patch fixes the first 3 problems using the following workflow:

    a) Create a disk-less backing.
    b) Create a virtual disk (single flat extent) from the non-streamOptimized
       image
    c) Attach the virtual disk to the backing
    d) Clone the backing (if needed) to perform disk provisioning type conversion

    Closes-Bug: #1287176
    Closes-Bug: #1287185
    Closes-Bug: #1284284
    Change-Id: Ib7e9fae81d69d2fe490a4b603337f3d5cee1138c