listing alarms shouldn't ordered by alarm id

Bug #1287119 reported by Liusheng
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
Wishlist
Ilya Tyaptin

Bug Description

Listing alarms is ordered by alarm id (an uuid), it is meaningless.
It should be ordered by creating time.

Liusheng (liusheng)
Changed in ceilometer:
assignee: nobody → Liusheng (liusheng)
Julien Danjou (jdanjou)
Changed in ceilometer:
status: New → Triaged
importance: Undecided → Low
importance: Low → Wishlist
Liusheng (liusheng)
Changed in ceilometer:
assignee: Liusheng (liusheng) → nobody
Revision history for this message
ZhiQiang Fan (aji-zqfan) wrote :

is there any plan to implement 'order by' feature in juno? or is just not so useful and can be an optional print argument in ceilometerclient?

Samta Rangare (srangare)
Changed in ceilometer:
assignee: nobody → samta (samtarangare)
Samta Rangare (srangare)
Changed in ceilometer:
assignee: sam (blr) → nobody
assignee: nobody → samta (srangare)
Samta Rangare (srangare)
Changed in ceilometer:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/106371

Revision history for this message
Nejc Saje (nejc-saje) wrote :

Wouldn't it make more sense for the alarms to be ordered alphabetically by their name?

Eoghan Glynn (eglynn)
Changed in ceilometer:
milestone: none → juno-3
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: juno-3 → juno-rc1
Revision history for this message
Ilya Tyaptin (ityaptin) wrote :

Issues with alarm ordering also are found in unit test class ceilometer.tests.storage.test_storage_scenarios.ComplexAlarmHistoryQueryTest[1]. In tests we use index in alarms list from alarm_conn.get_alarms() and in different backend index of alarm in this list is different.

CR for current bug does not affect this issue and I guess that order should to be fixed at storage level. As another approach - we can change unittest.

https://github.com/openstack/ceilometer/blob/master/ceilometer/tests/storage/test_storage_scenarios.py#L2598

Eoghan Glynn (eglynn)
Changed in ceilometer:
milestone: juno-rc1 → none
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to ceilometer (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/128255

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/128573

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on ceilometer (master)

Change abandoned by Samta Rangare (<email address hidden>) on branch: master
Review: https://review.openstack.org/127843
Reason: This patch is abandon.
Please refer: https://review.openstack.org/#/c/128573

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Samta Rangare (<email address hidden>) on branch: master
Review: https://review.openstack.org/106371
Reason: This patch is abandon.
Please refer: https://review.openstack.org/#/c/128573

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Ilya Tyaptin (<email address hidden>) on branch: master
Review: https://review.openstack.org/128255

Changed in ceilometer:
assignee: Samta Rangare (srangare) → Ilya Tyaptin (ityaptin)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/128573
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=b9d8b5832092128cb6ef6cf58e56ff8c4edf707d
Submitter: Jenkins
Branch: master

commit b9d8b5832092128cb6ef6cf58e56ff8c4edf707d
Author: Samta <email address hidden>
Date: Wed Oct 15 13:37:58 2014 +0530

    Alarms listing based on "timestamp"

    Fixes are proposed for ordering alarms based
    on "timestamp" in descending order.
    Existing tests has been modified at storage
    and api without breaking their functionality.

    One test case has been provided with this patch.

    Co-Authored-By: Ilya Tyaptin <email address hidden>

    Change-Id: Ie2bb950b6d32188f451f905e2cf07e4d938df1ac
    Closes-Bug: #1287119

Changed in ceilometer:
status: In Progress → Fix Committed
Eoghan Glynn (eglynn)
Changed in ceilometer:
milestone: none → kilo-1
Thierry Carrez (ttx)
Changed in ceilometer:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.