the LOG call in trove/instance/models.py could potentially raise a TypeError

Bug #1287097 reported by Ionuț Arțăriși
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
Fix Released
Low
Ionuț Arțăriși

Bug Description

The instance's status.status.api_status is logged before checking for the existence of the 'status.status'. That LOG call could potentially raise a TypeError when status.status is None and the check for status.status is never reached.

Changed in trove:
assignee: nobody → Ionuț Arțăriși (mapleoin)
status: New → In Progress
Changed in trove:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove (master)

Reviewed: https://review.openstack.org/74697
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=7a5051f96728ef58ad742e9989a2968062279240
Submitter: Jenkins
Branch: master

commit 7a5051f96728ef58ad742e9989a2968062279240
Author: Ionuț Arțăriși <email address hidden>
Date: Wed Feb 19 14:02:12 2014 +0100

    the check for status.status should happen before trying to log it

    otherwise, if status.status is None, status.status.api_status will throw
    a TypeError

    Closes-Bug: #1287097
    Change-Id: I62dafed59dcf8850808b22b8977d346607176403

Changed in trove:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in trove:
milestone: none → icehouse-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in trove:
milestone: icehouse-rc1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.