vim line in db migration template should be removed

Bug #1286991 reported by Akihiro Motoki
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Akihiro Motoki

Bug Description

We decided not to include vim lines for new files and we see review comments to suggest removing vim lines for new db migrations.

db migrations are generated from the template file: db/migration/alembic_migrations/script.py.mako

Removing the vim line from the template is helpful to avoid unnecessary review comments.

Tags: db
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/77513

Changed in neutron:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/77513
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=b481026c0e3f113142fd58d9d7894414f1441c84
Submitter: Jenkins
Branch: master

commit b481026c0e3f113142fd58d9d7894414f1441c84
Author: Akihiro Motoki <email address hidden>
Date: Mon Mar 3 14:57:42 2014 +0900

    Remove vim line from db migartion template

    This commit also empties __init__.py and removes vim
    modelines in the db migration related codes.

    Change-Id: I9f83109c5becb6cf7e2e6ad9ad8eb9af3d8e0972
    Closes-Bug: #1286991

Changed in neutron:
status: In Progress → Fix Committed
Changed in neutron:
milestone: none → icehouse-3
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: icehouse-3 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.