Unused variable remains

Bug #1286990 reported by Kiyohiro Adachi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
Fix Released
Low
Kiyohiro Adachi

Bug Description

o trove/backup/models.py:SWIFT_CONTAINER = CONF.backup_swift_container

This variable was added in the following commit.

  commit ce208d6cabba227576f492e7647d9da5a89e7c25
  Author: ruiyuan-shen <email address hidden>
  Date: Mon Mar 18 14:07:37 2013 -0700

    Add snapshot ORM to reddwarf

But there is no evidence that was used.

o trove/dns/rsdns/driver.py:DNS_HOSTNAME = CONF.dns_hostname

This variable was added in the following commit.

  commit 0c34c75dc44876245709987a18ea004607fca815
  Author: Sudarshan Acharya <email address hidden>
  Date: Fri May 18 15:49:12 2012 -0500

    DNS Support for Instance IP.

But there is no evidence that was used.

o trove/instance/models.py:SERVER_INVALID_ACTION_STATUSES
= ["BUILD", "REBOOT", "REBUILD", "RESIZE"]

This variable was removed in the following commit.

  commit 54a4ada785fd90af5134e7f38360938e0b435696
  Author: Ed Cranford <email address hidden>
  Date: Thu Jul 12 15:01:01 2012 -0500

    Delete can now delete errored instances.

o trove/instance/models.py:VALID_ACTION_STATUSES = ["ACTIVE"]

This variable was removed in the following commit.

  commit 9ccef6fea42454bb22c0d67bd4d2a0765f13d370
  Author: Tim Simpson <email address hidden>
  Date: Wed Jun 27 11:12:28 2012 -0500

    Allowing resizes to be performed when MySQL is down.

Commit messages of these were obtained from 'git log -p'.

Kiyohiro Adachi (adachi)
Changed in trove:
assignee: nobody → Kiyohiro Adachi (adachi)
Changed in trove:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove (master)

Reviewed: https://review.openstack.org/77075
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=506438b92f0afd729d5a49be4d5466aca15febba
Submitter: Jenkins
Branch: master

commit 506438b92f0afd729d5a49be4d5466aca15febba
Author: KIYOHIRO ADACHI <email address hidden>
Date: Fri Feb 28 14:43:31 2014 +0900

    Remove unused variables

    o trove/backup/models.py:SWIFT_CONTAINER = CONF.backup_swift_container

      This variable was added in the following commit.

        commit ce208d6cabba227576f492e7647d9da5a89e7c25
        Author: ruiyuan-shen <email address hidden>
        Date: Mon Mar 18 14:07:37 2013 -0700

            Add snapshot ORM to reddwarf

      But there is no evidence that was used.

    o trove/dns/rsdns/driver.py:DNS_HOSTNAME = CONF.dns_hostname

      This variable was added in the following commit.

        commit 0c34c75dc44876245709987a18ea004607fca815
        Author: Sudarshan Acharya <email address hidden>
        Date: Fri May 18 15:49:12 2012 -0500

            DNS Support for Instance IP.

      But there is no evidence that was used.

    o trove/instance/models.py:SERVER_INVALID_ACTION_STATUSES
       = ["BUILD", "REBOOT", "REBUILD", "RESIZE"]

      This variable was removed in the following commit.

        commit 54a4ada785fd90af5134e7f38360938e0b435696
        Author: Ed Cranford <email address hidden>
        Date: Thu Jul 12 15:01:01 2012 -0500

            Delete can now delete errored instances.

    o trove/instance/models.py:VALID_ACTION_STATUSES = ["ACTIVE"]

      This variable was removed in the following commit.

        commit 9ccef6fea42454bb22c0d67bd4d2a0765f13d370
        Author: Tim Simpson <email address hidden>
        Date: Wed Jun 27 11:12:28 2012 -0500

            Allowing resizes to be performed when MySQL is down.

    Closes-Bug: #1286990
    Change-Id: I79f5bb124f2702317d8d337c969c9ff8ea69a769

Changed in trove:
status: In Progress → Fix Committed
Changed in trove:
importance: Undecided → Low
status: Fix Committed → Fix Released
milestone: none → ongoing
status: Fix Released → Fix Committed
milestone: ongoing → juno-1
Thierry Carrez (ttx)
Changed in trove:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in trove:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.