CLI: Require -a

Bug #1286181 reported by Chris Johnston
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu CI Engine
Fix Released
Critical
Chris Johnston
Ubuntu CI Services
Fix Released
Critical
Chris Johnston

Bug Description

10:09:04 cjohnston | fginther: question... so we have this -a to add
extra packages (which then get added to the master package
                       | list on successful completion) and this -r to
remove extra packages (which then get removed from the master
                       | package list on successful completion)
10:09:34 cjohnston | Is something smart enough currently to add the
package that is being uploaded by the ticket? I don't think
                       | it is
10:10:27 fginther | cjohnston, the add portion should be working now.
The lander combines the -a list from the ticket and the
                       | return from the binarypackage api when passing the
package set to the image builder and test runner
10:10:50 fginther | cjohnston, but you just reminded me that there is
also an '-r' which isn't used yet. Filing a bug...
10:11:10 cjohnston | fginther: right.. but if I don't pass a -a, then
technically, my upload isn't being added, correct
10:11:56 doanac | without -a you don't do much of anything (from
what I can tell)
10:12:16 fginther | cjohnston, that would true, unless that package is
already in the golden list
10:12:26 fginther | which we're not there yet
10:12:28 Ursinha | should we default -a to be the list of binary
packages produced by the uploaded source then?
10:12:31 cjohnston | so, should we make -a required instead of allowing
a user to assume its in the golden list?
10:12:55 cjohnston | Ursinha: I don't think we want to open up the
potential of all binary packages produced by the upload do we?
10:13:04 fginther | Ursinha, no, there reasons we can't do that. A
source package could generate binary packages that conflict
                       | each other
10:13:24 cjohnston | so we should make -a required and leave -r as
optional
10:13:25 fginther | for one

 affects ubuntu-ci-services-itself
 status confirmed
 tag airline

Tags: airline

Related branches

Changed in ubuntu-ci-services-itself:
importance: Undecided → Critical
assignee: nobody → Chris Johnston (cjohnston)
milestone: none → phase-0
status: Confirmed → In Progress
Changed in ubuntu-ci-services-itself:
status: In Progress → Fix Committed
Changed in ubuntu-ci-services-itself:
status: Fix Committed → Fix Released
Ursula Junque (ursinha)
Changed in uci-engine:
status: New → Fix Released
importance: Undecided → Critical
assignee: nobody → Chris Johnston (cjohnston)
milestone: none → phase-0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.