neutron's extension loader behaviour is not consistent

[Sarath Menon]

We saw this in our startup logs:

2014-02-27 16:37:07,702 (neutron.api.extensions): INFO extensions add_extension Loaded extension: nvp-qos
2014-02-27 16:37:07,702 (neutron.api.extensions): INFO extensions _load_all_extensions_from_path Loading extension file: nvp_networkgw.py
2014-02-27 16:37:07,703 (neutron.api.extensions): DEBUG extensions _check_extension Ext name: Neutron-NVP Network Gateway
2014-02-27 16:37:07,703 (neutron.api.extensions): DEBUG extensions _check_extension Ext alias: network-gateway
2014-02-27 16:37:07,704 (neutron.api.extensions): DEBUG extensions _check_extension Ext description: Connects Neutron networks with external networks at layer 2 (deprecated).
2014-02-27 16:37:07,704 (neutron.api.extensions): DEBUG extensions _check_extension Ext namespace: http://docs.openstack.org/ext/neutron/network-gateway/api/v1.0
2014-02-27 16:37:07,705 (neutron.api.extensions): DEBUG extensions _check_extension Ext updated: 2014-01-01T00:00:00-00:00
2014-02-27 16:37:07,705 (neutron.api.extensions): INFO extensions add_extension Loaded extension: network-gateway
2014-02-27 16:37:07,705 (neutron.api.extensions): WARNING extensions _load_all_extensions_from_path Extension file nvp_networkgw.py wasn't loaded due to Found duplicate extension: network-gateway

There are two neutron servers load balanced, the other server did not show this. While running tempest against them, it was failing because both servers advertised different names for their network-gateway extension. Restarting neutron on the bad server did not show this behavior.

[Armando Migliaccio (armando-migliaccio)]

This is actually harmless behavior but I fix the warning, if desired.

[Armando Migliaccio (armando-migliaccio)]

forgot to add...I *could* fix the warning

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/78751

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/78754

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/78754
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=5ee168da8ef08226322ad416be4c099ddf781e4a
Submitter: Jenkins
Branch: master

commit 5ee168da8ef08226322ad416be4c099ddf781e4a
Author: armando-migliaccio <email address hidden>
Date: Thu Mar 6 12:45:37 2014 -0800

    Drop old nvp extension file

    The resource alias is unchanged so there is really
    no reason of dragging this forward.

    If API clients are using the name or the description
    in order to play with a server's extension they are
    doing it wrong so they deserve the grief caused
    by this change.

    Change-Id: I99086c11a0e4a0b0af479e0e3d1fbe92f8ff5988
    Closes-bug: #1285999

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/78751
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=7262ba713b50ab07a932ab7c8acf7ba1d838ff53
Submitter: Jenkins
Branch: master

commit 7262ba713b50ab07a932ab7c8acf7ba1d838ff53
Author: armando-migliaccio <email address hidden>
Date: Thu Mar 6 12:40:38 2014 -0800

    Makes the Extension loader behavior predictable

    When using a cluster of load-balanced Neutron Servers,
    the order of extension files being loaded may differ
    from one server to another. This is usually harmless,
    but it is better to force the list to be loaded in the
    same way across the entire cluster, just in case
    something funky is going on.

    Partial-bug: #1285999

    Change-Id: Ib0bfd24fc52b6cd9f90c350d3af496f04a90f50a