wsrep_sst_mysqldump error handling defective

[Daniel Black]

Line 120:

    || echo "SST failed to complete;") | $MYSQL

Piping "SST failed to complete" into the mysql process isn't very useful.

[Alex Yurchenko (ayurchen)]

But it gives you some idea about what is going on and aborts the client. Not very useful, but what "use" there can be in such a situation?

[Daniel Black (daniel-black)]

using wsrep_log_error to make it go to standard error and ensure that an exit code is returned

RC=0
MYRC=0
(echo $STOP_WSREP .......
|| RC=$? ) | $MYSQL || MYRC=$?
if [ "$MYRC" -ne 0 ]; then
wsrep_log_error "mysql failed with error $MYRC"
exit $MYRC
fi
if [ "$RC" -ne 0 ]; then
wsrep_log_error "mysqldump failed with error $RC"
exit $RC
fi

I'm assuming stderr is part of the sst interface and something useful happens to it? Didn't see it documented however: http://www.codership.com/wiki/doku.php?id=scriptable_state_snapshot_transfer