Inform admins via webui that the lander_service_wrapper can't get a PPA

Bug #1285360 reported by Ursula Junque
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu CI Engine
Fix Released
Medium
Andy Doan
Ubuntu CI Services
Fix Released
Medium
Andy Doan

Bug Description

Just discussed this issue. The rough solution we want to pursue:

1) the lander_service_wrapper that handles getting a free ppa should loop forever until it gets a ppa. This will allow us to only have a single artifact for the ticket (ie the lander won't keep re-launching the job).

2) We include service status into the webui. One of these would be the health of the ppa-assigner (ie ERROR: no free ppa's)

Tags: airline

Related branches

Ursula Junque (ursinha)
summary: - Ticket needs to be updated as Failed in case lander_ppa_assigner returns
- error
+ Ticket not updated as Failed when lander_ppa_assigner returns error
Revision history for this message
Francis Ginther (fginther) wrote : Re: Ticket not updated as Failed when lander_ppa_assigner returns error

This needs a bit of thought about the best action. Under normal circumstances, it could take a while for a ppa to become free after it's been recycled.

On second thought, I don't think outright failing the ticket is the right answer. Something should keep trying until a sufficiently long enough timeout is reached, or do we wait forever.

Revision history for this message
Francis Ginther (fginther) wrote :

The ppa_assigner should provide ppa availability in it's status API (which the web-ui will eventually call).

Revision history for this message
Ursula Junque (ursinha) wrote :

I agree it could have a timeout instead of failing right away, but we should update the ticket accordingly so the user knows what's going on. On my setup (that led to this bug) there were no PPAs available for the provided launchpad account, if only there was a way to check if the lp user has suitable PPAs in the beginning and fail right away it would be good (pretty sure that's not possible, though).

Revision history for this message
Chris Johnston (cjohnston) wrote : Re: [Bug 1285360] [NEW] Ticket not updated as Failed when lander_ppa_assigner returns error

Just curious, should the ticket fail because a free PPA can't be found? I
don't think we should be failing tickets for infra problems like this. It
isn't the tickets fault, and if we fail the ticket, isn't there a good
possibility that the next tickets will encounter the same issues?

Revision history for this message
Chris Johnston (cjohnston) wrote : Re: [Bug 1285360] Re: Ticket not updated as Failed when lander_ppa_assigner returns error

On Wed, Feb 26, 2014 at 4:28 PM, Francis Ginther <
<email address hidden>> wrote:

> This needs a bit of thought about the best action. Under normal
> circumstances, it could take a while for a ppa to become free after it's
> been recycled.
>
> On second thought, I don't think outright failing the ticket is the
> right answer. Something should keep trying until a sufficiently long
> enough timeout is reached, or do we wait forever.
>

Unless we can ensure that the problem is ticket related, and that the next
ticket won't fail too for the same reason, I would think we should wait
forever.

Evan (ev)
Changed in ubuntu-ci-services-itself:
assignee: nobody → Andy Doan (doanac)
Revision history for this message
Andy Doan (doanac) wrote : Re: Ticket not updated as Failed when lander_ppa_assigner returns error

Just discussed this issue. The rough solution we want to pursue:

1) the lander_service_wrapper that handles getting a free ppa should loop forever until it gets a ppa. This will allow us to only have a single artifact for the ticket (ie the lander won't keep re-launching the job).

2) We include service status into the webui. One of these would be the health of the ppa-assigner (ie ERROR: no free ppa's)

Changed in ubuntu-ci-services-itself:
importance: Undecided → Medium
Andy Doan (doanac)
Changed in ubuntu-ci-services-itself:
milestone: none → phase-0
summary: - Ticket not updated as Failed when lander_ppa_assigner returns error
+ Inform admins via webui that the lander_service_wrapper can't get a PPA
description: updated
Andy Doan (doanac)
Changed in ubuntu-ci-services-itself:
status: New → In Progress
Changed in ubuntu-ci-services-itself:
status: In Progress → Fix Committed
Changed in ubuntu-ci-services-itself:
status: Fix Committed → Fix Released
Ursula Junque (ursinha)
Changed in uci-engine:
assignee: nobody → Andy Doan (doanac)
importance: Undecided → Medium
milestone: none → phase-0
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.