Password is not quoted during cirros image upload

[keshavdv]

The password string is not quoted during in the system call in upload_cirros_image so passwords with special characters cause a 401 error:

c3314f03-6e06-4831-adb2-04dfbdb63aea: cmd: /usr/bin/glance -N http://172.28.101.2:5000/v2.0/ -T admin -I admin -K pa$$word image-create --name 'TestVM' --is-public true --container-format='bare' --disk-format='qcow2' --property murano_image_info='{"title": "Murano Demo", "type": "cirros.demo"}' --file '/usr/share/cirros-testvm/cirros-x86_64-disk.img'
                                               stdout:
                                               stderr: Invalid user / password (HTTP 401)
                                               exit code: 1

The $ signs cause a failure, quoting the password fixes the issue.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/76825

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/4.1
Review: https://review.openstack.org/76849

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/76825
Committed: https://git.openstack.org/cgit/stackforge/fuel-astute/commit/?id=69ad0455489abc97fde1048ce957c1f39c4cff54
Submitter: Jenkins
Branch: master

commit 69ad0455489abc97fde1048ce957c1f39c4cff54
Author: Matthew Mosesohn <email address hidden>
Date: Thu Feb 27 15:19:14 2014 +0400

    Escape credentials for cirros image upload

    Special characters could cause cirros image
    upload to fail. Shellquote.escape will ensure
    the password passed is valid.
    Also fixes typo in cirros image upload failure

    Change-Id: I3773385d05e91c87ddf56c251203f6a2068b1c16
    Closes-Bug: #1285318

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/76849
Committed: https://git.openstack.org/cgit/stackforge/fuel-astute/commit/?id=f15f5615249c59c826ea05d26707f062c88db32a
Submitter: Jenkins
Branch: stable/4.1

commit f15f5615249c59c826ea05d26707f062c88db32a
Author: Matthew Mosesohn <email address hidden>
Date: Thu Feb 27 15:19:14 2014 +0400

    Escape credentials for cirros image upload

    Special characters could cause cirros image
    upload to fail. Shellquote.escape will ensure
    the password passed is valid.
    Also fixes typo in cirros image upload failure

    Change-Id: I3773385d05e91c87ddf56c251203f6a2068b1c16
    Closes-Bug: #1285318

[Anastasiia Naboikina (anaboikina)]

verified on
{"ostf_sha": "31c8316d4d9762f280da9e360d3d42e88464aac1", "fuelmain_sha": "d494e5cf2b8399899f00b5079eec1c5f70c0b66f", "astute_sha": "8b45a579eb64f659791b6f207d7640b5a79f6c52", "release": "5.0", "nailgun_sha": "e3f45ac84c9f21d657c4253a18e7987dbe945b37", "fuellib_sha": "0f2765736a2e4af7265eeb936161f0a90cdc9a2e", "mirantis": "no"}