compute FakeDriver : DBerror invalid input syntax for integer: "1.0"

Bug #1285035 reported by Swann Croiset
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Joe Gordon

Bug Description

by setting nova.conf:
compute_driver = fake.FakeDriver

I got this error on conductor when nova-compute update_available_resource :
2014-02-26 08:48:04.631 ERROR oslo.messaging.rpc.dispatcher [-] Exception during message handling: (DataError) invalid input syntax for integer: "1.0"
LINE 1: ...6T07:48:04.627618'::timestamp, hypervisor_version='1.0' WHER...
                                                             ^
 'UPDATE compute_nodes SET updated_at=%(updated_at)s, hypervisor_version=%(hypervisor_version)s WHERE compute_nodes.id = %(compute_nodes_id)s' {'hypervisor_version': u'1.0', 'updated_at': datetime.datetime(2014, 2, 26, 7, 48, 4, 627618), 'compute_nodes_id': 1}
2014-02-26 08:48:04.631 TRACE oslo.messaging.rpc.dispatcher Traceback (most recent call last):
2014-02-26 08:48:04.631 TRACE oslo.messaging.rpc.dispatcher File "/home/croisets/stack/oslo.messaging/oslo/messaging/rpc/dispatcher.py", line 133, in _dispatch_and_reply
2014-02-26 08:48:04.631 TRACE oslo.messaging.rpc.dispatcher incoming.message))
2014-02-26 08:48:04.631 TRACE oslo.messaging.rpc.dispatcher File "/home/croisets/stack/oslo.messaging/oslo/messaging/rpc/dispatcher.py", line 176, in _dispatch
2014-02-26 08:48:04.631 TRACE oslo.messaging.rpc.dispatcher return self._do_dispatch(endpoint, method, ctxt, args)
2014-02-26 08:48:04.631 TRACE oslo.messaging.rpc.dispatcher File "/home/croisets/stack/oslo.messaging/oslo/messaging/rpc/dispatcher.py", line 122, in _do_dispatch
2014-02-26 08:48:04.631 TRACE oslo.messaging.rpc.dispatcher result = getattr(endpoint, method)(ctxt, **new_args)
2014-02-26 08:48:04.631 TRACE oslo.messaging.rpc.dispatcher File "/home/croisets/stack/nova/nova/conductor/manager.py", line 466, in compute_node_update
2014-02-26 08:48:04.631 TRACE oslo.messaging.rpc.dispatcher result = self.db.compute_node_update(context, node['id'], values)
2014-02-26 08:48:04.631 TRACE oslo.messaging.rpc.dispatcher File "/home/croisets/stack/nova/nova/db/api.py", line 228, in compute_node_update
2014-02-26 08:48:04.631 TRACE oslo.messaging.rpc.dispatcher return IMPL.compute_node_update(context, compute_id, values)
2014-02-26 08:48:04.631 TRACE oslo.messaging.rpc.dispatcher File "/home/croisets/stack/nova/nova/db/sqlalchemy/api.py", line 110, in wrapper
2014-02-26 08:48:04.631 TRACE oslo.messaging.rpc.dispatcher return f(*args, **kwargs)
2014-02-26 08:48:04.631 TRACE oslo.messaging.rpc.dispatcher File "/home/croisets/stack/nova/nova/db/sqlalchemy/api.py", line 166, in wrapped
2014-02-26 08:48:04.631 TRACE oslo.messaging.rpc.dispatcher return f(*args, **kwargs)
2014-02-26 08:48:04.631 TRACE oslo.messaging.rpc.dispatcher File "/home/croisets/stack/nova/nova/db/sqlalchemy/api.py", line 614, in compute_node_update
2014-02-26 08:48:04.631 TRACE oslo.messaging.rpc.dispatcher compute_ref.update(values)
2014-02-26 08:48:04.631 TRACE oslo.messaging.rpc.dispatcher File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/orm/session.py", line 456, in __exit__
2014-02-26 08:48:04.631 TRACE oslo.messaging.rpc.dispatcher self.commit()
2014-02-26 08:48:04.631 TRACE oslo.messaging.rpc.dispatcher File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/orm/session.py", line 368, in commit
2014-02-26 08:48:04.631 TRACE oslo.messaging.rpc.dispatcher self._prepare_impl()
2014-02-26 08:48:04.631 TRACE oslo.messaging.rpc.dispatcher File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/orm/session.py", line 347, in _prepare_impl
2014-02-26 08:48:04.631 TRACE oslo.messaging.rpc.dispatcher self.session.flush()
2014-02-26 08:48:04.631 TRACE oslo.messaging.rpc.dispatcher File "/home/croisets/stack/nova/nova/openstack/common/db/sqlalchemy/session.py", line 616, in _wrap
2014-02-26 08:48:04.631 TRACE oslo.messaging.rpc.dispatcher raise exception.DBError(e)
2014-02-26 08:48:04.631 TRACE oslo.messaging.rpc.dispatcher DBError: (DataError) invalid input syntax for integer: "1.0"
2014-02-26 08:48:04.631 TRACE oslo.messaging.rpc.dispatcher LINE 1: ...6T07:48:04.627618'::timestamp, hypervisor_version='1.0' WHER...
2014-02-26 08:48:04.631 TRACE oslo.messaging.rpc.dispatcher ^
2014-02-26 08:48:04.631 TRACE oslo.messaging.rpc.dispatcher 'UPDATE compute_nodes SET updated_at=%(updated_at)s, hypervisor_version=%(hypervisor_version)s WHERE compute_nodes.id = %(compute_nodes_id)s' {'hypervisor_version': u'1.0', 'updated_at': datetime.datetime(2014,
2, 26, 7, 48, 4, 627618), 'compute_nodes_id': 1}

Revision history for this message
Swann Croiset (swann-w) wrote :

precision : with postgresql backend

Changed in nova:
status: New → Triaged
importance: Undecided → Low
assignee: nobody → Joe Gordon (jogo)
Revision history for this message
Joe Gordon (jogo) wrote :

we don't gate on postgres + fake virt and hypervisor_version should be an int

Changed in nova:
status: Triaged → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/76582

Changed in nova:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/76582
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=026583e60e9ec2b83049e8ceee16f182560d2562
Submitter: Jenkins
Branch: master

commit 026583e60e9ec2b83049e8ceee16f182560d2562
Author: Joe Gordon <email address hidden>
Date: Wed Feb 26 14:34:10 2014 -0800

    Make hypervisor_version an int in fakeVirt driver

    This is a follow up to 9e770e62135fe9c2c8ac0121a5a79245b25a7847, which
    missed the change in a duplicate copy of host_status.

    Add regression test to test_virt_drivers.

    This requires changes to the API samples, because they were wrong. virt
    drivers use convert_version_to_int which converts a version string to a
    4 digit number ("1.0" becomes to 1000)

    Change-Id: I28ce23509e3c9feae183a49a8fc5bf3c7c601295
    Closes-Bug: #1285035

Changed in nova:
status: In Progress → Fix Committed
Changed in nova:
milestone: none → juno-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: juno-2 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.