Awn

trash applet shouldn't go over the horizontal bar

Bug #128490 reported by haytjes
4
Affects Status Importance Assigned to Milestone
Awn
Fix Released
Medium
Michal Hruby

Bug Description

The reflection of the trash applet is 4px to long ( in the MacOSX look). It should stop 4px from the border to let the horizontal bar come on the front.
The tasks already have this option, but it should be done in the trash applet too.

haytjes (h4writer)
Changed in awn:
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
haytjes (h4writer) wrote :

This fixes the reflection of the Trash going to low on the 3D look.

Now there is still ONE issue way it shouldn't be merged yet:
If the bar_angle equals zero (=flat bar look) it shouldn't remove the 4px off the bottom. But as far as I know it isn't possible to retrieve that information for the moment :-( So for the moment it always chop the 4px off the bottom...

Changed in awn:
status: Confirmed → In Progress
haytjes (h4writer)
Changed in awn:
assignee: nobody → h4writer
Revision history for this message
Isaac Joseph (isaacj87) wrote :

Patch fails!

patching file applets/trash/trashapplet.c
Hunk #1 FAILED at 343.
1 out of 1 hunk FAILED -- saving rejects to file applets/trash/trashapplet.c.rej

Revision history for this message
haytjes (h4writer) wrote :

Strange it should work. I remade it, but still I don't see the differents between the both patches...

Revision history for this message
Miika-Petteri Matikainen (mpmatikainen) wrote :

I'd say not to commit this patch before it works with flat view.

Revision history for this message
Isaac Joseph (isaacj87) wrote :

I forgot to get back to you on the patch haytjes...it now works great with 3D look...I didn't test it with a flat look.

Michal Hruby (mhr3)
Changed in awn:
assignee: h4writer → mhr3
status: In Progress → Fix Committed
Changed in awn:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.