TPAC metarecord / formats repairs and usability additions

[Bill Erickson]

Evergreen 2.6

Further testing of the TPAC metarecords and icon / search formats has revealed a few bugs and some usability issues:

- multi-format records not showing all formats in record detail page

- patron barcode not propagating from title hold to MR hold when selecting 'advanced hold options' in staff client after entering a barcode

- would be helpful to see in search results if a record has multiple constituents

- building composite defs from scratch can be time consuming and error prone; should be able to clone CCVM's

- building composite defs, catalogers are more accustomed to CCVM codes than labels in some cases (e.g. marc item type). UI would be much better if it showed the codes as well.

- last, but not least, we need seed data for the tpac format selector, since sharing the icon_selector is causing issues, the main one being that when icon formats are configured like search formats, many items will appear with multiple icons that shouldn't.

Code in progress...

[Bill Erickson (berick)]

Code in progress at:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1284864-tpac-mr-formats-repairs-and-usability

I've pushed fixes for all but the format seed data. Starting on that soon.

[Bill Erickson (berick)]

I've pushed a collection of seed data for a new search_format attribute.
---

    Creates a new search_format record attribute, which is responsible for
    driving the catalog search format selector. The values are derived from
    the icon_format attriute, with a few notable changes (for starters).

    1. The 'book' search_format contains large print and has the label "All
    Books".

    2. The 'music' search_format contains all music, regardless of sound
    record format (or other attributes) and has the label "All Music"
---

That's everything I wanted to do. Adding pullrequest...

[Bill Erickson (berick)]

Removing pullrequest. There are a few more issues I'd like to repair. Details to follow shortly...

[Bill Erickson (berick)]

Additional fixes pushed:

* limit the bib records list for a metarecord to those with opac-visible copies within the search scope
* MR constituent record count display for also honors search scope
* Improved wording for holds placement -- make it clear that selecting no formats (or langs) is equivalent to allowing any format/lang to fill the hold
* Repaired format icons display for both MR and non-MR holds in the myaccount holds list.
* If no holdable formats exist for a MR hold, disallow the hold.

[Bill Erickson (berick)]

* fixed another issue where the constituent record information was based on opac-visible copies in one context and based on holdable copies in another within search results. Now constituent record info is always based on opac-visible copies for search and display, and based on holdable copies only for holds placement / editing.

Adding pullrequest tag back.

[Bill Erickson (berick)]

lightly squashed branch pushed to

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1284864-tpac-mr-formats-repairs-and-usability-squash

[Mike Rylander (mrylander)]

And here is a secondary branch covering related issues having to do with the leaking of deleted bib records in a metarecord context: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/miker/metarecord-deleted-constituents

[Mike Rylander (mrylander)]

I think the branches at the end of this bug represent some significant cleanup that needs to be folded into master before RC. I'm going to push Bill's in now (it's tested very well), and mine is working for Ben Shum in testing, AFAIK.

[Ben Shum (bshum)]

I can confirm that berick's changes are good (they're in anyways) but I also pushed in Mike's fix for deleted bibs and metarecords.