Instance with volume attached not properly suspended

[Paul Van Eck]

When creating a stack with an instance that utilizes its "Volumes" property (like below), a problem arises when trying to suspend the stack. After issuing the "action-suspend" subcommand, the stack will eventually go into the "SUSPEND_COMPLETE" state. However, upon further inspection, one will see that the volume has been successfully detached, but the instance is still ACTIVE. This means one cannot successfully resume the stack because a conflict error will arise saying, "Cannot 'resume' while instance is in vm_state active (HTTP 409)."

Template:

{
 "Resources" : {
     "Ec2Instance" : {
         "Type" : "AWS::EC2::Instance",
         "Properties" : {
    "InstanceType" : "m1.small",
             "ImageId" : "F17-x86_64-cfntools",
             "Volumes" : [
            { "VolumeId" : { "Ref" : "NewVolume" },
              "Device" : "/dev/vdb"
            }
    ]
         }
     },
     "NewVolume" : {
       "Type" : "AWS::EC2::Volume",
       "Properties" : {
         "Size" : "3",
         "AvailabilityZone" : "nova"
        }
  }
 }
}

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/76126

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/76126
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=f136980e65823d40a89c29532f244add75ed685b
Submitter: Jenkins
Branch: master

commit f136980e65823d40a89c29532f244add75ed685b
Author: Paul Van Eck <email address hidden>
Date: Tue Feb 25 00:45:26 2014 -0800

    Allow proper instance with volume suspension

    When suspending a stack that contains an instance with a volume
    attached through the instance's "Volumes" property, the stack will
    go into a SUSPEND_COMPLETE state, but the actual instance will still
    be in an ACTIVE state. This is because check_suspend_complete will
    return TRUE without ever starting the instance's suspend task.
    This commit ensures that the instance suspension TaskRunner is
    actually started.

    Change-Id: I77291d21b291242684cf42e7143b264521ba113e
    Closes-Bug: #1284306