refactor code of solution for bug/1267431

Bug #1284189 reported by Sergey Vasilenko
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
High
Sergey Vasilenko

Bug Description

refactor code of solution for bug/1267431:
* make workable with minimal incoming parameters
* remove unnided incoming parameters in functions
* FIX tests

https://review.openstack.org/#/c/75837
https://launchpad.net/bugs/1267431

Changed in fuel:
importance: Undecided → High
assignee: nobody → Sergey Vasilenko (xenolog)
milestone: none → 5.0
status: New → Confirmed
Changed in fuel:
status: Confirmed → Triaged
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (master)

Fix proposed to branch: master
Review: https://review.openstack.org/80508

Changed in fuel:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/80508
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=c397c9e0be79493b035b5f9d536e3736ecf4a628
Submitter: Jenkins
Branch: master

commit c397c9e0be79493b035b5f9d536e3736ecf4a628
Author: Sergey Vasilenko <email address hidden>
Date: Fri Mar 14 11:48:47 2014 +0400

    Refactoring code that gives possibility define admin tenant name for Neutron.

    In this commit removed unnecessary parameters.
    Tenant's name gets from Neutron config if given there, from fuel_config hash
    if not given in Neutron config and set to "admin" if not given anywhere.

    Closes-bug: #1284189
    Change-Id: I9476e6fb81552a9b58d8573c2f587fde417871cd

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (stable/4.1)

Fix proposed to branch: stable/4.1
Review: https://review.openstack.org/96863

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (stable/4.1)

Reviewed: https://review.openstack.org/96863
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=4f0bd39b8f5d8ee86ad8e5a8b9ada5ac6437643d
Submitter: Jenkins
Branch: stable/4.1

commit 4f0bd39b8f5d8ee86ad8e5a8b9ada5ac6437643d
Author: Sergey Vasilenko <email address hidden>
Date: Fri Mar 14 11:48:47 2014 +0400

    Refactoring code that gives possibility define admin tenant name for Neutron.

    In this commit removed unnecessary parameters.
    Tenant's name gets from Neutron config if given there, from fuel_config hash
    if not given in Neutron config and set to "admin" if not given anywhere.

    Closes-bug: #1284189
    Change-Id: I9476e6fb81552a9b58d8573c2f587fde417871cd

Revision history for this message
Meg McRoberts (dreidellhasa) wrote :

Not documented in 4.1.1 Release Notes

Changed in fuel:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.