Handle source packages that don't have a version bump from a prior upload
Bug #1284153 reported by
Francis Ginther
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu CI Engine |
Fix Released
|
High
|
Francis Ginther | ||
| Ubuntu CI Services |
Fix Released
|
High
|
Francis Ginther | ||
Bug Description
Every source package needs to have a unique and monotonically increasing source package version for each ticket. Failure to do so will result in failed builds.
We should document the basis for this limitation and provide and provide an example. Also document how building from a source MP and injecting a version string should eliminate this problem after phase 0.
The branch source builder should check the packages uploaded to the build and archive ppa before building and fail a ticket that would fail to build or copy.
Related branches
lp:~fginther/ubuntu-ci-services-itself/bsbuilder-fixes
- Francis Ginther: Needs Fixing
-
Diff: 819 lines (+449/-97)11 files modifiedbranch-source-builder/bsbuilder/resources/v1.py (+2/-2)
branch-source-builder/bsbuilder/run_worker.py (+113/-30)
branch-source-builder/bsbuilder/tests/test_upload.py (+89/-0)
branch-source-builder/bsbuilder/tests/test_v1.py (+2/-2)
branch-source-builder/cupstream2distro/packageinppamanager.py (+4/-7)
branch-source-builder/setup.py (+4/-0)
branch-source-builder/upload_package.py (+47/-35)
branch-source-builder/watch_ppa.py (+163/-8)
juju-deployer/branch-source-builder.yaml.tmpl (+1/-1)
lander/bin/lander_service_wrapper.py (+12/-12)
lander/bin/ticket_api.py (+12/-0)
lp:~doanac/ubuntu-ci-services-itself/bsbuilder-better-error-handling
- Francis Ginther: Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 470 lines (+273/-40)5 files modifiedbranch-source-builder/bsbuilder/run_worker.py (+103/-23)
branch-source-builder/cupstream2distro/packageinppamanager.py (+4/-7)
branch-source-builder/setup.py (+2/-1)
branch-source-builder/watch_ppa.py (+163/-8)
juju-deployer/branch-source-builder.yaml.tmpl (+1/-1)
| summary: |
- Document the need for bumping the source package version when submitting - new tickets + Handle source packages that don't have a version bump from a prior + upload |
| tags: | added: airline |
| Changed in ubuntu-ci-services-itself: | |
| assignee: | nobody → Francis Ginther (fginther) |
| Changed in ubuntu-ci-services-itself: | |
| milestone: | none → phase-0 |
| Changed in ubuntu-ci-services-itself: | |
| status: | New → In Progress |
| importance: | Undecided → High |
Revision history for this message
| Francis Ginther (fginther) wrote | #1 |
| Changed in ubuntu-ci-services-itself: | |
| status: | In Progress → Fix Committed |
| Changed in ubuntu-ci-services-itself: | |
| status: | Fix Committed → Fix Released |
| Changed in uci-engine: | |
| assignee: | nobody → Francis Ginther (fginther) |
| importance: | Undecided → High |
| milestone: | none → phase-0 |
| status: | New → Fix Released |
To post a comment you must log in.
I have some prototype code which does this. Just need to finish integration with the run_worker and provide some meaningful output.