Router should not log signals (during select()) as warnings

Bug #1284137 reported by Bill Erickson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenSRF
Fix Released
Low
Unassigned

Bug Description

Currently, messages like this are generated by the router as warnings.

2014-02-21 12:25:13 scrapple router: [WARN:5883:osrf_router.c:223:] Top level select call interrupted by signal
2014-02-21 12:25:13 scrapple router: [WARN:5883:osrf_router_main.c:157:] Interrupted by signal 15; re-raising

These signals are normal and usually indicate the router is shutting down, so they should not be logged as warnings.

Branch in progress...

Tags: pullrequest
Revision history for this message
Bill Erickson (berick) wrote :

Code:

http://git.evergreen-ils.org/?p=working/OpenSRF.git;a=shortlog;h=refs/heads/user/berick/lp1284137-router-shutdown-signal-logging

The logs now read:

2014-02-24 09:26:16 scrapple router: [INFO:24050:osrf_router.c:223:] Router shutting down

2014-02-24 09:26:16 scrapple router: [DEBG:24050:osrf_router_main.c:157:] Router received signal 15; re-raising

Note if the signal received in router_main is not a shutdown signal, it will be logged as a WARNing within the router, so we're not losing information.

tags: added: pullrequest
Changed in opensrf:
assignee: Bill Erickson (erickson-esilibrary) → nobody
milestone: none → 2.3.0-beta
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed to master and rel_2_3. Thanks, Bill!

Changed in opensrf:
status: New → Fix Committed
importance: Undecided → Low
Galen Charlton (gmc)
Changed in opensrf:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.