Make metaplugin be used with a router service plugin

[OpenStack Infra]

https://review.openstack.org/65034
commit c04785e0ced18ebab6bada1d3961c1394c541a69
Author: Itsuro Oda <email address hidden>
Date: Mon Jan 6 15:03:14 2014 +0900

    Make metaplugin be used with a router service plugin

    "l3_plugin_list" configuration parameter of the metaplugin is permitted
    blank now.
    If "l3_plugin_list" is blank, router extension and extensions which extend
    the router extension don't be included in "supported-extension-aliases" of
    the metaplugin.
    This makes the metaplugin be able to be used with a router service plugin.
    Note that if "l3_plugin_list" is not blank, a router service plugin must
    not be specified, otherwise the error of the bug report still occurs.

    This patch removes some router extension related meaningless codes also.
    (e.g. external-net extension belongs to L2 functionality and be handled
     by core plugins properly.)

    Closes-bug: 1266347
    DocImpact

    Change-Id: I0454bc0a4bd7eda5dad18b0538fb7baebe0b9f91

[Tom Fifield (fifieldt)]

This really needs some updates in the helptext of the string upstream

[Itsuro Oda (oda-g)]

I think it was not appropriate that I added 'DocImpact' to the commit message.
The target document is http://docs.openstack.org/trunk/config-reference/content/networking-plugin-meta.html (which is generated from source code).
It is not necessary to change itself.
The topic which introduced by the commit is covered by detail comments added in sample metaplugin.ini .

[Tom Fifield (fifieldt)]

Hi, Oda san,

Thank you for your comment.

In my opinion, this text is good:
"""
 If you use a router service plugin, set 'l3_plugin_list' blank.
 If 'l3_plugin_list' is not blank, must not specify a router service
 plugin in 'service_plugins' of neutron.conf.
"""

However, I feel that perhaps it could be added to the help text of the l3_plugin_list option in the code.

At the moment, "(StrOpt) List of L3 plugins to load" is fairly basic, and maybe not so informative for the user :)

[Itsuro Oda (oda-g)]

Hi Tom,

I understand. I will submit the fix shortly.

[Itsuro Oda (oda-g)]

I submitted the fix https://review.openstack.org/#/c/88114/ .
I welcome correcting my poor English.

[Openstack Gerrit (openstack-gerrit)]

Reviewed: https://review.openstack.org/88114
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=e95571a6e350338a1567234bc934f70f83e69d86
Submitter: Jenkins
Branch: master

commit e95571a6e350338a1567234bc934f70f83e69d86
Author: Itsuro Oda <email address hidden>
Date: Wed Apr 16 10:46:29 2014 +0900

    Make help texts more descriptive in Metaplugin

    This patch makes help texts of configuration parameters of
    metaplugin.ini more descriptive. Comments in metaplugin.ini
    are also improved.

    Change-Id: I1fac888ecc223a7199cc9c9aeb603b7493f22171
    Closes-Bug: #1283930

[Itsuro Oda (oda-g)]

The fix https://review.openstack.org/#/c/88114/ is merged.

Original fix (65034) of this bug report is related to the configuration guide. So it was unnecessary to add 'DocImpact' to the commit message. (I was pointed out from a neutron core later.)

According to Tom's suggestion, I made the fix(88114) which improves help text much.
(This fix is only related to the configuration guide too. So I did not add 'DocImpact' at this time.)

I think this bug can be closed.

[Nachi Ueno (nati-ueno)]

Thanks