Internal errors happen if passing malformed body to attach_interface API

[Ken'ichi Ohmichi]

"Attach an interface to an instance" v2 API does not validate whether necessary attribute is specified or not.
The lack causes internal errors now.

[Jaspreet (walia-jaspreet)]

I can confirm that I have encountered same issue .

When following create interface api is called with empty body , http Error code 500 is returned making it difficult for end-user to debug the issue.

Example:
--------------
https://example.com:2020/v2/0371a910e818429f88498857276d8a0a/
servers/f5144641-2671-491b-91f6-2318537a2cf5/os-interface

Request Body
{
  "interfaceAttachment": {}
}

Response
{
    "computeFault": {
        "message": "The server has either erred or is incapable of performing the requested operation.",
        "code": 500
    }
}

This is not useful to end-user and doesn't tell user what the parameters are missing. Ideally it should throw 400 Error code.

[Christopher Yeoh (cyeoh-0)]

I don't think this is an issue anymore? It appears some other internal fixes have also fixed this bug too