Regression in NSX op status synchronization logic

[Salvatore Orlando]

While performing tests on the async status synchronization logic, it emerged that state changes are not being anymore written to the neutron database by the sync thread.

The sync thread correctly reads data from the backend but then does not update the status for changed objects.
The regression might have been caused by recent changes in ID mapping logic or by other bug fixes on the sync logic.

Reproduction step:

- Artificially put a NSX resource down, for instance by removing the GW service for a router
- Wait for synchronization
- After synchronization, the status in the DB is not updated.

Punctual state synchronization still works correctly.

[Salvatore Orlando (salvatore-orlando)]

The issue was introduced with the router db mappings patch (b70dce2), and it affected routers only.

A patch will be pushed soon.

[Salvatore Orlando (salvatore-orlando)]

And of course it did not affect routers only!

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/76046

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/76005
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=ec3dfc93da605b7c41682951f2fd1e27fb09d53b
Submitter: Jenkins
Branch: master

commit ec3dfc93da605b7c41682951f2fd1e27fb09d53b
Author: Salvatore Orlando <email address hidden>
Date: Mon Feb 24 10:44:46 2014 -0800

    NSX: Fix status sync with correct mappings

    The code that syncs router status to the neutron_db was using the nsx
    router id instead of the neutron router id thus synchronize_router
    would never update the database.

    Also, the switch synchronization routine was not fetching the
    appropriate neutron id tag thus causing switch synchronization to
    be skipped.

    This patch also fixes the error in the unit tests which allowed for
    the bug to be introduced.

    Co-Authored-By: Salvatore Orlando <email address hidden>
    Closes-bug: 1283856

    Change-Id: I26342ecea6ad546b224b7fca1e55f754b4883363

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/83273