ovs plugin changes port it shouldn't change

Bug #1283765 reported by Vincent Untz
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Rossella Sblendido
Havana
Fix Released
Undecided
Unassigned

Bug Description

(Using ML2 with ovs)

While playing with https://github.com/stackforge/cookbook-openstack-network/blob/master/files/default/neutron-ha-tool.py to migrate routers between L3 agents, I had the issue that the connectivity got lost.

After investigating, it turns out that interface for the port of the router that is connected to the external network (attached to br-public -- which is usually named br-ext) gets a tag. Manually removing the tag makes things work.

I'm attaching a bit of the log where the port_update message is received (it's received for the two interfaces of the router, so this needs some care when reading). We can see the following:
 Running command: ['sudo', '/usr/bin/neutron-rootwrap', '/etc/neutron/rootwrap.conf', 'ovs-vsctl', '--timeout=2', 'set', 'Port', 'qg-923f9b0e-aa', 'tag=2']

However, reading the code, it seems that this kind of actions should only be done for ports on br-int (because of "vif_port = self.int_br.get_vif_port_by_id(port['id'])"). So this shouldn't be run for other ports.

Revision history for this message
Vincent Untz (vuntz) wrote :
Changed in neutron:
assignee: nobody → Vincent Untz (vuntz)
status: New → In Progress
Vincent Untz (vuntz)
tags: added: havana-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/75702

Revision history for this message
Vincent Untz (vuntz) wrote :

Note: I hit this on Havana, haven't been able to test Icehouse.

Changed in neutron:
assignee: Vincent Untz (vuntz) → Rossella Sblendido (rossella-o)
Akihiro Motoki (amotoki)
Changed in neutron:
importance: Undecided → Medium
milestone: none → icehouse-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/75702
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=9bc29208bda6071a34bcc0da36a396eb8bab4f30
Submitter: Jenkins
Branch: master

commit 9bc29208bda6071a34bcc0da36a396eb8bab4f30
Author: Vincent Untz <email address hidden>
Date: Sun Feb 23 17:57:05 2014 +0100

    Fix get_vif_port_by_id to only return relevant ports

    This is returning any port, even if it's not on the switch that we're
    looking at. As a side-effect, this means that we can actually manipulate
    these ports while we really shouldn't.

    Co-Authored-By: Rossella Sblendido <email address hidden>
    Change-Id: Ia4f4e93237c1c2ea6cb4b6c2f5adf78d6b34c7bf
    Closes-Bug: #1283765

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/havana)

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/78945

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/85270

Thierry Carrez (ttx)
Changed in neutron:
milestone: icehouse-3 → 2014.1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/havana)

Reviewed: https://review.openstack.org/85270
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=fe7eef495fc917adac4090af9fe1c4e98178912d
Submitter: Jenkins
Branch: stable/havana

commit fe7eef495fc917adac4090af9fe1c4e98178912d
Author: rossella <email address hidden>
Date: Tue Mar 4 16:36:19 2014 +0100

    Fix get_vif_port_by_id to only return relevant ports

    This is returning any port, even if it's not on the switch that we're
    looking at. As a side-effect, this means that we can actually manipulate
    these ports while we really shouldn't.

    Backported from 9bc2920

    Change-Id: Ia4f4e93237c1c2ea6cb4b6c2f5adf78d6b34c7bf
    Closes-Bug: #1283765

tags: added: in-stable-havana
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.