Weather AP tests assume tablet mode
Bug #1283266 reported by
Nicholas Skaggs
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu Weather App |
Fix Released
|
High
|
Martin Borho | ||
Bug Description
The autopilot tests populate fake data a part of the test process, but the data populated assumes the UI is in tablet mode. The tests should reflect the UI changes implemented for tablet mode vs phone layout.
Related branches
lp:~martin-borho/ubuntu-weather-app/anchors-refactoring
- Nicholas Skaggs (community): Approve
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
-
Diff: 1146 lines (+212/-409)17 files modifiedcomponents/AddLocationSheet.qml (+30/-14)
components/ChartComponent.js (+0/-197)
components/ChartComponent.qml (+0/-63)
components/CurrentWeather.qml (+3/-7)
components/DateComponent.qml (+14/-34)
components/LastUpdatedComponent.qml (+10/-5)
components/LocationManagerSheet.qml (+30/-10)
components/LocationTab.qml (+46/-29)
components/ScrollingArea.qml (+2/-2)
components/SettingsSheet.qml (+1/-0)
components/SplashComponent.qml (+8/-6)
components/TabFooter.qml (+36/-19)
components/WeatherApi.js (+2/-8)
tests/autopilot/ubuntu_weather_app/tests/__init__.py (+6/-2)
tests/autopilot/ubuntu_weather_app/tests/test_mainview.py (+3/-1)
tests/autopilot/ubuntu_weather_app/tests/test_settings.py (+17/-9)
ubuntu-weather-app.qml (+4/-3)
| Changed in ubuntu-weather-app: | |
| status: | New → Triaged |
| importance: | Undecided → High |
| Changed in ubuntu-weather-app: | |
| assignee: | nobody → Martin Borho (martin-borho) |
Revision history for this message
| Nicholas Skaggs (nskaggs) wrote | #1 |
Revision history for this message
| Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote | #2 |
| Changed in ubuntu-weather-app: | |
| status: | Triaged → Fix Committed |
| Changed in ubuntu-weather-app: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
It appears this is actually a hotfix in the qml itself, which martin will revert to properly support phone and tablet UI and update the tests accordingly.