HA broken due to Puppet dependency cycle

[Ryan Moe]

{"build_id": "2014-02-21_20-39-54", "mirantis": "yes", "build_number": "178", "nailgun_sha": "f786786894acc331a4b53b31f33e373ef95ccdfc", "ostf_sha": "b8f16a0288cbf39e11e0b4a41a3f63e6b87dcc4b", "fuelmain_sha": "fe157dcc0c68a237b527cb9b6adf9101c815e374", "astute_sha": "3d43abeefb60677ce6cae83d31ebbba1ff3cdbe2", "release": "4.1", "fuellib_sha": "f8e3a24938478e3983cfbc883fab07cdee4a1c87"}

Ubuntu HA Neutron VLAN
3 controllers, 1 compute, 1 cinder

Controllers fail with:

err: Could not apply complete catalog: Found 1 dependency cycle:
(File[/etc/glance/] => Class[Glance] => File[create_sheepdog_override] => Package[sheepdog] => Package[glance] => Class[Glance])
Try the '--graph' option and opening the resulting '.dot' file in OmniGraffle or GraphViz

However, the UI shows the controllers as ready instead of error.

[Dmitry Borodaenko (angdraug)]

The dependency cycle was introduced in https://review.openstack.org/75432 which attempted to fix https://bugs.launchpad.net/fuel/+bug/1283050

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/75498

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/75498
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=7cdf5c5f1d1eead175ea07722d53a0f9c8d4ef30
Submitter: Jenkins
Branch: master

commit 7cdf5c5f1d1eead175ea07722d53a0f9c8d4ef30
Author: Dmitry Borodaenko <email address hidden>
Date: Fri Feb 21 12:22:26 2014 -0800

    Revert "Add Sheepdog package to dependency chain of Glance."

    This reverts commit 2abfac4183020d5c2c696f1e6e93a32b4aafc98a.

    Change-Id: I23d1753be11334c940966cf479c892971f76aabf
    Closes-bug: #1283187

[Dmitry Ilyin (idv1985)]

Looks like we can just remove tweaks::ubuntu_service_override it's not actually needed here.

Also that dependency cicle is far from obvious and could be detected only by manual or automatic testing.

[Andrey Sledzinskiy (asledzinskiy)]

Verified on ISO #214

Revision: 6e6f6b31b8880b7600a1af5cc94d48ac01d60a07
origin/master