[FFe] Provide a lock screen and unlock dialogs in Unity

[Stephen M. Webb]

[FFe]

The merge proposal for this work missed the feature freeze dealine by a few hours and requires a freeze exception.

This bug replaces the original FFe file under bug #878836.

--- original description ---

We need to provide a thematically compatible lock screen and unlock dialogs in Unity, consistent with the unity-greeter authentication dialog used in LightDM. This will replace gnome-screenlocker.

[Iain Lane (laney)]

On Thu, Feb 20, 2014 at 10:46:13PM -0000, Stephen M. Webb wrote:
> ** Description changed:
>
> + [FFe]
> +
> + The merge proposal for this work missed the feature freeze dealine by a
> + few hours and requires a freeze exception.

I don't think so, since the merge isn't even approved yet.

I think it seems reasonable, but can you outline the plan / timescale
for the a11y fixes that the MP mentions?

Does it share the logo with unity-greeter? We just started having this
generated at build-time, see:

  https://code.launchpad.net/~xnox/unity-greeter/off-the-grid/+merge/205896

& /usr/share/unity-greeter/logo.png

so you don't need to ship it statically any more.

 status incomplete

Cheers,

--
Iain Lane [ <email address hidden> ]
Debian Developer [ <email address hidden> ]
Ubuntu Developer [ <email address hidden> ]

[Iain Lane (laney)]

See https://code.launchpad.net/~laney/unity-greeter/data-package/+merge/207644 which will let you use unity-greeter's logo.png

[Andrea Azzarone (azzar1)]

@Iain
More or less 1 week for the a11y fixes:
 - OSK already works well
 - screen reader works for the panel, just need to fix it for the text entry.
 - high contrast, we already support if for the top panel, sould not be that hard to add the support for the text entry.

Thanks for the info about the logo.

[Sebastien Bacher (seb128)]

Note that the behaviour is configurable, so it's easy to fallback to use gnome-screensaver if the new lock screen turns out to be an issue (e.g we don't lock ourself in that direction by merging the work)

[Andrea Azzarone (azzar1)]

Orca screen reader now works fine.

[Iain Lane (laney)]

Is this ready to be uploaded right now? If not, when will it be?

@Seb, how is it configured?

[Sebastien Bacher (seb128)]

@laney: you can configure it in ccsm but apparently that's not need, super-L should work out of the box for locking.

We need to patch the gnome-screensaver api users though I guess (at least indicator-session and unity-settings-daemon)

[Iain Lane (laney)]

I was referring to "Note that the behaviour is configurable, so it's easy to fallback to use gnome-screensaver" but having to patch things doesn't sound that easy?

[Sebastien Bacher (seb128)]

Oh, right. It's easy to change the unity setting to use its locker or g-s, I'm not sure what it means for the clients though. Unity team, care to comment on that?

[Andrea Azzarone (azzar1)]

If the client talk directly to gnome-screensaver we cannot do that much. A good client should use the standard freedesktop interface.

[Sebastien Bacher (seb128)]

Right, still before swapping pieces we need to know the impact on the user experience. If we have non-well-behaved clients in our default installation those needs to be fixed when we land the feature...

[Marco Trevisan (Treviño) (3v1n0)]

This is the patch that is needed in gnome-screensaver in order to get the proper unity integration.

[Iain Lane (laney)]

OK. I've had a look at this request. Thanks for the patch to g-s. I had a brief look at it and I'm not sure why you introduced the lock-request signal? What happens if the lock fails in manager_lock_request? I think you leak the GSignals too.

That's only a review from quickly looking at the diff - someone else should review it properly.

Anyway, I want to give a chance for this to get into Trusty, but I want to be conservative. So I'll ack this FFe if you can get it in by Wednesday this week (2014-03-12). We're a month away from final freeze now and I'm keen to give this as good a run of user testing as possible before the LTS release.

If not, then I don't want to nack the request—find another RT member (I'll be away this week) to re-review the state and see if you can try again.

Please keep an eye on bug reports and feedback and if this doesn't go as smoothly as we need then we should be prepared to go back to the known current state and land this solidly next cycle.

[Marco Trevisan (Treviño) (3v1n0)]

Thanks for the FFe approval, then:

> I'm not sure why you introduced the lock-request signal?

I didn't want to make GSManager (that is a child of GSMonitor) to keep a reference (even a weak one) of its parent, so the quickest way and the one that wouldn't have involved too many changes to the GS code, was to emit a signal that returns a value if the lock is handled.

So, in case unity is running and a lock has been requested, if nothing fails, unity will handle it and GS will ignore the lock.

> What happens if the lock fails in manager_lock_request? I think you leak the GSignals too.

If something fails here, the signal will return FALSE, an thus, the normal GS locking will happen; in case unity will be back (if it has ever been there), then we replace the g-s locking with the native unity locking again.

> I think you leak the GSignals too.

You mean the connections?
Btw I've pushed a new version of the patch...

[Sebastien Bacher (seb128)]

https://launchpad.net/ubuntu/+source/gnome-screensaver/3.6.1-0ubuntu10

[Sebastien Bacher (seb128)]

https://launchpad.net/ubuntu/+source/unity/7.1.2+14.04.20140311-0ubuntu1

[Stephen M. Webb (bregma)]

Fix Released in Unity Unity 7.2.0.