Ignoring network id during instance launching

[Sergey Kraynev]

I have met strange behavior of nova API.
When we create instance and send request with network parameters (port_id, network_id, fixed_ip) with not None values,
nova ignore network_id without any message. As result we get instance only with pointed port_id.
In case when we send same request using interface-attach we get BadRequest answer here
https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/contrib/attach_interfaces.py#L96
because we have port_id and network_id together in request.

Also I have look in v3 plugins and it have a little difference.
If we have not None value for port_id and fixed_ip, will be raised Error
https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/plugins/v3/servers.py#L348
but it still ignore network_id.

If it's normal behavior: Could you explain why nova send BadRequest Error in same case during attaching interface.

[Cedric Brandily (cbrandily)]

Responding BadRequest when port_id and network_id are both provided seems the correct behavior.
Indeed it explicits the mistakes to specify both where the other solution implicitly use only network_id

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/77174

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sean Dague (<email address hidden>) on branch: master
Review: https://review.openstack.org/77174
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[Davanum Srinivas (DIMS) (dims-v)]

Removing "In Progress" status and assignee as change is abandoned.

[Markus Zoeller (markus_z) (mzoeller)]

This is an automated cleanup. This bug report has been closed because it
is older than 18 months and there is no open code change to fix this.
After this time it is unlikely that the circumstances which lead to
the observed issue can be reproduced.

If you can reproduce the bug, please:
* reopen the bug report (set to status "New")
* AND add the detailed steps to reproduce the issue (if applicable)
* AND leave a comment "CONFIRMED FOR: <RELEASE_NAME>"
  Only still supported release names are valid (LIBERTY, MITAKA, OCATA, NEWTON).
  Valid example: CONFIRMED FOR: LIBERTY