Wrong error message in OSTF

[Gleb]

Health Check failed during the launch new VM . Then it says that test failed (without any details).

The real reason was TestVM image didn't exist in glance.
I dug this up in ostf-stdin.log after I spend a lot of time trying to find out what is wrong.

It would be nice if we have special single test if TestVM is available or not.

Or maybe we should show more informative error messages.

[Anastasiia Naboikina (anaboikina)]

We have a smoke test that verifies that TestVM image exists, which is called "Launch instance, create snapshot, launch instance from snapshot", the first step of which is verification if testVM image is available. But it doesn`t mention TestVM image exactly when failed. Also, we have a sanity test which requests a list of images and fails if list is empty. Tests that create instances just try to retrieve image to create an instance, that`s why when it`s not available they just provide a message that instance creation failed.

I agree with the idea of providing an informative error message. And also, I think we should change error message of "Launch instance, create snapshot, launch instance from snapshot" test so that it mentions the name of image it fails to get (in our case it`s TestVM)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/75077

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/4.1
Review: https://review.openstack.org/76863

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/75077
Committed: https://git.openstack.org/cgit/stackforge/fuel-ostf/commit/?id=8b69f81e1fab565a6209ba41f226e82d1b672487
Submitter: Jenkins
Branch: master

commit 8b69f81e1fab565a6209ba41f226e82d1b672487
Author: Anstasiia Naboikina <email address hidden>
Date: Thu Feb 20 17:48:33 2014 +0200

    Add verification that TestVM image exists

    Added method that verifies if TestVM instance exists.
    Added method invocation to all tests that use default
    image. Moved get_image_from_name method to
    OfficialClientTest class.

    Change-Id: I9404e312009b2f98d0a3904f347fe3c1e4a8fc1d
    Closes-bug: #1282456

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/76863
Committed: https://git.openstack.org/cgit/stackforge/fuel-ostf/commit/?id=2e44e9399687f8f512104da5d8689f83f9ac243a
Submitter: Jenkins
Branch: stable/4.1

commit 2e44e9399687f8f512104da5d8689f83f9ac243a
Author: Anstasiia Naboikina <email address hidden>
Date: Thu Feb 20 17:48:33 2014 +0200

    Add verification that TestVM image exists

    Added method that verifies if TestVM instance exists.
    Added method invocation to all tests that use default
    image. Moved get_image_from_name method to
    OfficialClientTest class.

    Change-Id: I9404e312009b2f98d0a3904f347fe3c1e4a8fc1d
    Closes-bug: #1282456

[Andrey Sledzinskiy (asledzinskiy)]

verified on 112-with-gerrit iso