Tarmac

get_review_url is unnecessary

Bug #1282353 reported by dobey
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Tarmac
Fix Released
High
dobey

Bug Description

The get_review_url code in tarmac.utility is unneeded, as the LP API has the web_link property on branch_merge_proposal objects, which points to the web page for the proposal. We should use this instead.

Related branches

lp:~dobey/tarmac/merge-web-link
Mike McCracken: Approve
Diff: 158 lines (+19/-46)
5 files modified
tarmac/bin/commands.py (+2/-4)
tarmac/plugins/commitmessage.py (+1/-2)
tarmac/plugins/tests/test_commitmessage.py (+4/-2)
tarmac/tests/test_commands.py (+12/-28)
tarmac/utility.py (+0/-10)
Tarmac Traffic Controller (tarmac-atc)
Changed in tarmac:
status: In Progress → Fix Committed
dobey (dobey)
Changed in tarmac:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.