puppet master relative code in nailgun

Bug #1282108 reported by Igor Shishkin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
Medium
Evgeniy L

Bug Description

Hello,

just found the following:

in ./nailgun/nailgun/task/task.py
246 try:
247 node_db = db().query(Node).get(node['id'])
248 if node_db and node_db.fqdn:
249 node_hostname = node_db.fqdn
250 else:
251 node_hostname = TaskHelper.make_slave_fqdn(node['id'])
252 logger.info("Removing node cert from puppet: %s",
253 node_hostname)
254 cmd = "puppet cert clean {0}".format(node_hostname)

Tags: nailgun
Revision history for this message
Evgeniy L (rustyrobot) wrote :

The problem is that we don't have puppet muster anymore, but we have hardcoded command to clean certificates from puppet master.

Changed in fuel:
assignee: nobody → Evgeniy L (rustyrobot)
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/74736

Changed in fuel:
status: Triaged → In Progress
summary: - puppet master relative code in naigun
+ puppet master relative code in nailgun
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/74736
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=b5eea18a35c2e971aa52a9a9190dcbe55b16e563
Submitter: Jenkins
Branch: master

commit b5eea18a35c2e971aa52a9a9190dcbe55b16e563
Author: Evgeniy L <email address hidden>
Date: Wed Feb 19 18:28:25 2014 +0400

    Remove dead code where we were removing certificates from puppet master

    Puppet master was removed from Fuel admin node
    as result we don't need to remove puppet certificates.

    Closes-bug: #1282108
    Change-Id: I2ab3f624199c5db24fb91a355e979225bb24f5fc

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
Andrey Sledzinskiy (asledzinskiy) wrote :

verified

Changed in fuel:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.