Threadpool adds connection without notifying audit plugin

Bug #1282008 reported by fengyi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona Server moved to https://jira.percona.com/projects/PS
Fix Released
Medium
Sergei Glushchenko
5.1
Invalid
Undecided
Unassigned
5.5
Fix Released
Medium
Sergei Glushchenko
5.6
Fix Released
Medium
Sergei Glushchenko

Bug Description

MYSQL_AUDIT_NOTIFY_CONNECTION_CONNECT(thd) should be called after login_connection in threadpool_add_connection.

Tags: threadpool

Related branches

Revision history for this message
Valerii Kravchuk (valerii-kravchuk) wrote :

This is what we have in 5.6:

openxs@ao756:~/bzr/percona-5.6$ grep -rn "MYSQL_AUDIT_NOTIFY_CONNECTION_CONNECT(thd)" *
sql/sql_connect.cc:1452: MYSQL_AUDIT_NOTIFY_CONNECTION_CONNECT(thd);
sql/sql_audit.h:182:#define MYSQL_AUDIT_NOTIFY_CONNECTION_CONNECT(thd) mysql_audit_notify(\
openxs@ao756:~/bzr/percona-5.6$ grep -rn login_connection * sql/threadpool_common.cc:215: if (!login_connection(thd))
sql/sql_connect.cc:1258: login_connection()
sql/sql_connect.cc:1270:bool login_connection(THD *thd)
sql/sql_connect.cc:1274: DBUG_ENTER("login_connection");
sql/sql_connect.cc:1275: DBUG_PRINT("info", ("login_connection called by thread %lu",
sql/sql_connect.cc:1451: rc= login_connection(thd);
sql/sql_connect.h:46:bool login_connection(THD *thd);

and 5.5:

openxs@ao756:~/bzr/percona-5.6$ cd ../percona-5.5
openxs@ao756:~/bzr/percona-5.5$ grep -rn "MYSQL_AUDIT_NOTIFY_CONNECTION_CONNECT(thd)" *
sql/sql_connect.cc:1333: MYSQL_AUDIT_NOTIFY_CONNECTION_CONNECT(thd);
sql/sql_audit.h:174:#define MYSQL_AUDIT_NOTIFY_CONNECTION_CONNECT(thd) mysql_audit_notify(\
openxs@ao756:~/bzr/percona-5.5$ grep -rn login_connection * sql/threadpool_common.cc:150: if (!login_connection(thd))
sql/sql_connect.cc:1143: login_connection()
sql/sql_connect.cc:1155:bool login_connection(THD *thd)
sql/sql_connect.cc:1159: DBUG_ENTER("login_connection");
sql/sql_connect.cc:1160: DBUG_PRINT("info", ("login_connection called by thread %lu",
sql/sql_connect.cc:1332: rc= login_connection(thd);
sql/sql_connect.h:46:bool login_connection(THD *thd);

tags: added: threadpool
Revision history for this message
Shahriyar Rzayev (rzayev-sehriyar) wrote :

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PS-1476

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.