Clean up deprecation warnings caused by puppet module updates

[Mark T. Voelker]

Due to updates in the upstream puppet modules over time, we emit a few variable deprecation warnings during catalog runs. We should clean these up. Known deprecation warnings (I'm intentionally ommitting naginator warnings here for the moment since we're debating the future of that module):

Warning: Scope(Class[Neutron::Server]): sql_connection deprecated for connection
Warning: Scope(Class[Neutron::Server]): sql_idle_timeout deprecated for idle_timeout
Warning: Scope(Class[Nova]): sql_connection deprecated for database_connection
Warning: Scope(Class[Horizon]): keystone_host, keystone_port and keystone_scheme are deprecated. Use keystone_url instead.
Warning: Scope(Class[Horizon]): keystone_host, keystone_port and keystone_scheme are ignored when keystone_url is set.

Warning: Scope(Class[Nova::Keystone::Auth]): cinder parameter is deprecated and has no effect.
Warning: Hiera file /etc/puppet/data/hiera_data/vendor/cisco_coi_user.common.yaml should contain a hash

Note: there are some deprecation warnings emitted from various modules due to things like @ signs missing from templates. I'll track those separately as they will require fixes to individual modules rather than fixes to puppet_openstack_builder. The errors above should be fixable with changes to the composition layer alone.

[Mark T. Voelker (mvoelker)]

> Warning: Hiera file /etc/puppet/data/hiera_data/vendor/cisco_coi_user.common.yaml should contain a hash

This one is actually specific to the COI version of puppet_openstack_builder since the upstream version doesn't have the file mentioned in the warning (in the COI version it's an empty placeholder, hence the warning).

Pull request to fix:
https://github.com/CiscoSystems/puppet_openstack_builder/pull/56

[Mark T. Voelker (mvoelker)]

> Warning: Scope(Class[Horizon]): keystone_host, keystone_port and keystone_scheme are deprecated. Use keystone_url instead.
> Warning: Scope(Class[Horizon]): keystone_host, keystone_port and keystone_scheme are ignored when keystone_url is set.

I'm going to hold off on addressing this until the following conversation is sorted out upstream...depending on the outcome here we may or may not need to compose the URI ourselves, or we may refactor how they're supplied/what they're supplied to.

https://groups.google.com/a/puppetlabs.com/forum/#!topic/puppet-openstack/c-gqL91ltXg

We'll track this as a separate bug once consensus has been reached on the keystone parameter format.

[Mark T. Voelker (mvoelker)]

Path for the rest of these warnings:

https://review.openstack.org/74593

[Mark T. Voelker (mvoelker)]

Note that some additional warnings of this form are also currently seen:

Warning: Scope(Class[Neutron::Server]): sql_max_retries deprecated for max_retries
Warning: Scope(Class[Neutron::Server]): sql_idle_timeout deprecated for idle_timeout
Warning: Scope(Class[Neutron::Server]): reconnect_interval deprecated for retry_interval

These will be resolved by https://review.openstack.org/#/c/71117/ once it's pulled in. No change to the puppet_openstack_builder is needed for these as they're being triggered by the existence of a bug in puppet-neutron itself.

[Mark T. Voelker (mvoelker)]

Notice: Scope(Class[Ntp]): autoupdate parameter has been deprecated and replaced with package_ensure. Set this to latest for the same behavior as autoupdate => true.

This one isn't actually the composition layer's fault: it's set in puppet-coi. Resolved by:
https://github.com/CiscoSystems/puppet-coi/pull/42

[Mark T. Voelker (mvoelker)]

Naginator:
https://github.com/CiscoSystems/puppet-naginator/pull/21

[Mark T. Voelker (mvoelker)]

Stable backport for swift fixes:
https://review.openstack.org/75477