fuel cli removes all nodes when misspelt

Bug #1281153 reported by Andrey Danin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
High
Alexandr Notchenko

Bug Description

When you forgot set appropriate node-id's, the Fuel CLI drops roles and cluster_id for all nodes in DB.

[root@fuel ~]# fuel --env 2 node 14 --delete

Nodes with ids [1, 2, 3, 4, 5, 6, 7, 8, 9, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 27, 28, 29, 30, 31, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43] were removed from environment with id 2.

Tags: cli
summary: - fuel cli removes all nodes when misspellt
+ fuel cli removes all nodes when misspelt
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to fuel-web (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/74102

Changed in fuel:
assignee: Fuel Python Team (fuel-python) → Alexandr Notchenko (anotchenko)
Mike Scherbakov (mihgen)
Changed in fuel:
milestone: 5.0 → 4.1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/74333

Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/74333
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=84daaf298f59874eb56dafd81a1bf0834c4c8d22
Submitter: Jenkins
Branch: master

commit 84daaf298f59874eb56dafd81a1bf0834c4c8d22
Author: Alexandr Notchenko <email address hidden>
Date: Tue Feb 18 15:23:00 2014 +0400

    Added --all to stop accedental node removal

     * Added --all flag for removing all nodes
     from selected environment.
     * Added error message for implicit node
     deletion

     Closes-bug: #1281153

    Change-Id: I5b70eb9994b64c300032a079758a708985f47f5a

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
Egor Kotko (ykotko) wrote :

Verifyed on:
{"build_id": "2014-02-28_01-17-30", "mirantis": "yes", "build_number": "225", "nailgun_sha": "12a7e7a99557f2bc302f0806ad3beef02e94b974", "ostf_sha": "ceb3ea8c2c0da27306b30b9936f27dbc5044d2c6", "fuelmain_sha": "ba019bf15a9597a154e7c1d6ecc840614d21414c", "astute_sha": "f15f5615249c59c826ea05d26707f062c88db32a", "release": "4.1", "fuellib_sha": "61d3a150402da3ce1160836c8d659f6d9d1f9640"}

Egor Kotko (ykotko)
Changed in fuel:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.