scan.py assumes printer has 'Flatbed' source. Printer only has 'Auto' and 'ADF'

[comtek_it]

scan.py from hplip-3.14.1 sets our HP 2840 to ADF mode, even when ADF is not specified.

This seems to be due to the line:

   if 'Flatbed' not in source_option and 'ADF' in source_option:

Reverting to:

   if len(source_option) == 1 and 'ADF' in source_option:

fixes it (although of course we get an error 'error: Unable to set option source to value Flatbed' when doing non-ADF scans.

The printers in question only have "Auto" and "ADF" in source_option.

[Sarbeswar Meher (sarbeswar-meher)]

Please do the following steps.

- Open /usr/share/hplip/data/models/models.dat file in root mode.
- Search for [hp_color_laserjet_2840] section. Change scan-src=1 to scan-src=3.
- Save the file.
- Now run hp-scan or xsane.

Please inform us your result.

[Stefano Rivera (stefanor)]

Same story with a 3390, scan-src=3 didn't help.

hp-scan[17290]: debug: Supported source Options: ['Auto', 'ADF'] size=2
hp-scan[17290]: debug: Device has only ADF support

comtek_it's patch looks reasonable to me.