resource-list fails for ResourceGroup

Bug #1280391 reported by andrew plunk
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
High
Sergey Kraynev

Bug Description

The following patch breaks resource-list for the ResourceGroup: https://review.openstack.org/#/c/65970/6/heat/engine/api.py

Doing a resource-list on a stack with a ResourceGroup will result in the following exception:

2014-02-14 11:24:11.313 31495 TRACE root AttributeError: 'NoneType' object has no attribute 'resources'
2014-02-14 11:24:11.313 31495 TRACE root Traceback (most recent call last):
2014-02-14 11:24:11.313 31495 TRACE root
2014-02-14 11:24:11.313 31495 TRACE root File "/opt/heat/lib/python2.7/site-packages/heat/openstack/common/rpc/amqp.py", line 462, in _process_data
2014-02-14 11:24:11.313 31495 TRACE root **args)
2014-02-14 11:24:11.313 31495 TRACE root
2014-02-14 11:24:11.313 31495 TRACE root File "/opt/heat/lib/python2.7/site-packages/heat/openstack/common/rpc/dispatcher.py", line 172, in dispatch
2014-02-14 11:24:11.313 31495 TRACE root result = getattr(proxyobj, method)(ctxt, **kwargs)
2014-02-14 11:24:11.313 31495 TRACE root
2014-02-14 11:24:11.313 31495 TRACE root File "/opt/heat/lib/python2.7/site-packages/heat/engine/service.py", line 62, in wrapped
2014-02-14 11:24:11.313 31495 TRACE root return func(self, ctx, *args, **kwargs)
2014-02-14 11:24:11.313 31495 TRACE root
2014-02-14 11:24:11.313 31495 TRACE root File "/opt/heat/lib/python2.7/site-packages/heat/engine/service.py", line 815, in list_stack_resources
2014-02-14 11:24:11.313 31495 TRACE root for resource in stack.values()]
2014-02-14 11:24:11.313 31495 TRACE root
2014-02-14 11:24:11.313 31495 TRACE root File "/opt/heat/lib/python2.7/site-packages/heat/engine/api.py", line 129, in format_stack_resource
2014-02-14 11:24:11.313 31495 TRACE root resource.nested().resources.itervalues()]
2014-02-14 11:24:11.313 31495 TRACE root
2014-02-14 11:24:11.313 31495 TRACE root AttributeError: 'NoneType' object has no attribute 'resources'

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/73677

Changed in heat:
assignee: nobody → andrew plunk (andrew-plunk)
status: New → In Progress
Changed in heat:
assignee: andrew plunk (andrew-plunk) → Keith Bray (keith-bray)
Changed in heat:
assignee: Keith Bray (keith-bray) → Sergey Kraynev (skraynev)
Steven Hardy (shardy)
Changed in heat:
milestone: none → icehouse-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/78363
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=b57401e5028611b53e6412efa225b0c03e8c89ac
Submitter: Jenkins
Branch: master

commit b57401e5028611b53e6412efa225b0c03e8c89ac
Author: Sergey Kraynev <email address hidden>
Date: Wed Mar 5 14:05:26 2014 -0500

    Revert "Showing member list for nested resources"

    This reverts commit 5e883e94d73cb7fd6737c262f25cd7c6be56ffe5.

    Reverted patch not fully resolve problem that was mentioned in bug
    description, since presented in resource show ids are owned nested stack
    and it doesn't allow use only resource-show command for displaying
    information of these resources.
    Also this code affects not only resource group resource, but other
    nested resources too. So it leads to displaying some unwanted
    information.

    Conflicts:

     heat/tests/test_engine_service.py

    Closes-bug: #1280391
    Change-Id: Id965e1f872ebf63a510242c7c76a4f105dcb4a17

Changed in heat:
status: In Progress → Fix Committed
Changed in heat:
importance: Undecided → High
Thierry Carrez (ttx)
Changed in heat:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: icehouse-rc1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.