OpenStack Compute (nova)

Replace exception re-raises with excutils.save_and_reraise_exception() in the Hyper-V driver

Bug #1280363 reported by Alessandro Pilotti
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Alessandro Pilotti
OpenStack Compute (nova) 2014.1 "icehouse"
Havana
Fix Released
Undecided
Unassigned
OpenStack Compute (nova) 2013.2.4

Bug Description

A few methods of the Hyper-V driver ops classes use a catch / raise pattern that replaces original exceptions with specific domain exceptions inherited from vmutils.HyperVUtilsException(). The original exception is thus masqueraded and trackable only by analysing the logs.

Alessandro Pilotti (alexpilotti)
tags: added: hyper-v
Changed in nova:
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Alessandro Pilotti (alexpilotti)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/73646

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/73646
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=80ffc9b8b38293c05c9d48cb615b24fd7255a850
Submitter: Jenkins
Branch: master

commit 80ffc9b8b38293c05c9d48cb615b24fd7255a850
Author: Alessandro Pilotti <email address hidden>
Date: Fri Feb 14 18:22:25 2014 +0200

    Replaces exception re-raising in Hyper-V

    In a few cases in the Hyper-V driver classes, generic exceptions
    are getting caught, logged and a domain specific exception is raised.

    This creates issues in identifying the exception cause programmatically
    (e.g. in unit tests).

    This patch enforces the usage of excutils.save_and_reraise_exception()

    Closes-Bug: #1280363

    Change-Id: I27cc54941c5f592ea567ccaa8fa369362da1427f

Changed in nova:
status: In Progress → Fix Committed
Russell Bryant (russellb)
Changed in nova:
milestone: none → icehouse-rc1
Alessandro Pilotti (alexpilotti)
summary: Replace exception re-raises with excutils.save_and_reraise_exception()
- in the HYper-V driver
+ in the Hyper-V driver
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/havana)

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/84144

Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: icehouse-rc1 → 2014.1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/havana)

Reviewed: https://review.openstack.org/84144
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=5aab5f03cdef70accdd67369944a28495713d660
Submitter: Jenkins
Branch: stable/havana

commit 5aab5f03cdef70accdd67369944a28495713d660
Author: Alessandro Pilotti <email address hidden>
Date: Fri Feb 14 18:22:25 2014 +0200

    Replaces exception re-raising in Hyper-V

    In a few cases in the Hyper-V driver classes, generic exceptions
    are getting caught, logged and a domain specific exception is raised.

    This creates issues in identifying the exception cause programmatically
    (e.g. in unit tests).

    This patch enforces the usage of excutils.save_and_reraise_exception()

    Closes-Bug: #1280363

    (cherry-picked from commit 80ffc9b8b38293c05c9d48cb615b24fd7255a850)

    Change-Id: I27cc54941c5f592ea567ccaa8fa369362da1427f

tags: added: in-stable-havana
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.