check if export is already mounted before mounting it (LibvirtNFSVolumeDriver)
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Compute (nova) |
Fix Released
|
Wishlist
|
Leandro Ignacio Costantino |
Bug Description
At the moment there is no check in _mount_nfs if the export is already mounted. It will be tried to mount the export and if the export is already mounted an exception is thrown following in a WARNING message that the export is already mounted. This pollutes the logs with useless WARNING messages and if there is a real exception (for example the NFS export is not reachable) we only have a WARNING in the logs.
def _mount_nfs(self, mount_path, nfs_share, options=None, ensure=False):
"""Mount nfs export to mount path."""
# Construct the NFS mount command.
nfs_cmd = ['mount', '-t', 'nfs']
if CONF.libvirt.
if options is not None:
try:
except processutils.
if ensure and 'already mounted' in exc.message:
else:
affects: | horizon → nova |
Changed in nova: | |
assignee: | nobody → Leandro Ignacio Costantino (leandro-i-costantino) |
status: | New → Incomplete |
status: | Incomplete → In Progress |
Changed in nova: | |
milestone: | none → icehouse-rc1 |
Changed in nova: | |
status: | Fix Committed → Fix Released |
Changed in nova: | |
milestone: | icehouse-rc1 → 2014.1 |
I patchset is in review: https:/ /review. openstack. org/#/c/ 75029/