ironic.conf.sample missing options from common.service

Bug #1280064 reported by Ruby Loo
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Low
Ruby Loo

Bug Description

The two config options in common.service, periodic_interval and host, are not in the ironic.conf.sample file.

openstack/common/config/generator.py looks for a variable that is a list of config options. The code in common.service was written with the list passed as an argument to cfg.CONF.register_opts(), instead of being assigned to a variable first, so the generator didn't detect it.

Ruby Loo (rloo)
Changed in ironic:
assignee: nobody → Ruby Loo (rloo)
status: New → Triaged
importance: Undecided → Low
milestone: none → icehouse-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/73488

Changed in ironic:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/73488
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=89d835e1b3243021d370191cc2bc213713735e2d
Submitter: Jenkins
Branch: master

commit 89d835e1b3243021d370191cc2bc213713735e2d
Author: Ruby Loo <email address hidden>
Date: Fri Feb 14 03:15:54 2014 +0000

    Add common.service config options to sample

    openstack/common/config/generator.py looks for a variable that is a list
    of config options. The code in common.service was written with the list
    passed as an argument to cfg.CONF.register_opts(), instead of being
    assigned to a variable first, so the generator didn't detect it.

    In common.service, the list of config options is now assigned to a variable.
    The ironic.conf.sample file generated by tools/config/generate_sample.sh
    now includes the two config options: periodic_interval and host.

    Change-Id: I2f42e7f407ffc157d225652045c1bf53f65405b3
    Closes-Bug: #1280064

Changed in ironic:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ironic:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ironic:
milestone: icehouse-3 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.