Intermittent unit tests failures in NSX plugin

[Salvatore Orlando]

Observed here: http://logs.openstack.org/92/71692/12/check/gate-neutron-python26/496b1b1/console.html

This behaviour might have been introduced by the patch for introducing a mapping between neutron and nsx uuids for networks.

[Armando Migliaccio (armando-migliaccio)]

Actually this might have been introduced by this patch:

https://review.openstack.org/#/c/54584/

which is the mapping between nsx routers uuid and neutron's

[Armando Migliaccio (armando-migliaccio)]

And interestingly it happens only on python26 tests...at least so far.

[Salvatore Orlando (salvatore-orlando)]

logstash query: http://logstash.openstack.org/#eyJzZWFyY2giOiJtZXNzYWdlOlwiZm9yZWlnbiBrZXkgY29uc3RyYWludCBmYWlsZWRcIiBhbmQgbWVzc2FnZTpcIklOU0VSVCBJTlRPIG5ldXRyb25fbnN4X25ldHdvcmtfbWFwcGluZ3NcIiIsImZpZWxkcyI6W10sIm9mZnNldCI6MCwidGltZWZyYW1lIjoiNjA0ODAwIiwiZ3JhcGhtb2RlIjoiY291bnQiLCJ0aW1lIjp7InVzZXJfaW50ZXJ2YWwiOjB9LCJzdGFtcCI6MTM5MjM3Mzg0MDEwMH0=

It always happens with the same unit test.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/73636

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/73832

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/73832
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=95807c9436be7eb34fe37289d76fb4611ab77783
Submitter: Jenkins
Branch: master

commit 95807c9436be7eb34fe37289d76fb4611ab77783
Author: Salvatore Orlando <email address hidden>
Date: Sat Feb 15 11:46:37 2014 -0800

    Skip a test for nicira service plugin

    test_router_add_interface_subnet_with_port_from_other_tenant
    is causing intermittent failures in unit tests because of
    issues related with sql session autoflush.

    This patch skips this test, since it is already covered
    by another test case in the same module. This should prevent
    job failures while the relevant bug is addressed.

    Change-Id: Iad33dada61d17fad14e569e241f4079465b5f792
    Related-Bug: 1280035

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/75305

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/75313

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/73636
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=fcad26e394cd6021aab2c94f1179533cc7866f8c
Submitter: Jenkins
Branch: master

commit fcad26e394cd6021aab2c94f1179533cc7866f8c
Author: Salvatore Orlando <email address hidden>
Date: Fri Feb 14 08:17:30 2014 -0800

    Use different context for each API request in unit tests

    test_router_add_interface_subnet_with_port_from_other_tenant in
    neutron.tests.unit.test_l3_plugin.L3NatTestCaseBase was mocking
    neutron.context.Context thus performing multiple API requests
    with the same context instance. As a context instance also has
    a DB session attribute, this might cause unexpected side effects,
    especially for plugins which process request asynchronously.

    The plugin neutron.plugins.nicira.NeutronServicePlugin was being
    affected.

    This patch ensures each request has a different context object
    without changing the unit test semantics.

    It also refactors slightly test_edge_router.py in the nicira
    unit test package to avoid executing twice the same unit tests.

    Change-Id: I4895faa00ebd915eb9e259930db2d004a9e78a86
    Closes-Bug: #1280035