Event starting at 0:00 displayed also the day before in day view

[ybon]

When I have an event that start at 0:00, it displayed both for the correct day and for the day before.
See attachment.

[ybon (yohanboniface)]

Also in Week view, see attachment.

[ybon (yohanboniface)]

Patch attached.
This is a proposal.
Naming: I would suggest to rename midnight in startOfDay, to have a logic.
Tests: I haven't made any unittest, I still need to figure out how to run them before :)
(testrun.sh is expecting a "nexus" hostname and I'm not sure how to achieve this given that adb is running on localhost with a specific port. To be resolved :) )

Thanks for feedback :)

[Kunal Parmar (pkunal-parmar)]

HI Ybon,

I see you proposed patch, can you proposed Merge Request instead ?

[ybon (yohanboniface)]

Yep, for sure!
I was hopping to be able to run autopilot tests before, and to add one to prevent future regressions, but I'm still stuck on this side: if I use default packages of Saucy, tests fail because of not inheriting from the correct version of python-autopilot lib; if I try to use autopilot/experimental or autopilot/1.4 ppa, qmlscene freezes at each test (maybe, but not sure, because I'm unable to have the autopilot-desktop 1.4, which as a dependency on gir1 1.39, which is unavailable for Saucy) :/
I'm really uncomfortable with pushing things without running tests nor adding dedicated ones.
But in this case, which is supposed to be a small fix, do you want me to propose a MR anyway?

[ybon (yohanboniface)]

Here it is: https://code.launchpad.net/~yohanboniface/ubuntu-calendar-app/fix1279933/+merge/208970

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

Fix committed into lp:ubuntu-calendar-app at revision None, scheduled for release in ubuntu-calendar-app, milestone alpha-1