"Action Required" statuses still show the 'in progress' icon

Bug #1279878 reported by Julie Pichon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Thai Tran

Bug Description

On the Instances table, when we're not waiting for an action to finish but expecting the user to perform an action, we should show the correct "action required" icon. It looks like this was lost along the way.

How to reproduce:
1. Resize an instance
2. Wait for the resizing actions to be finished until the "Confirm Resize/Migrate" button pops up in the actions drop-down

Expected result: 3. The status column icon changes to the 'question mark' icon

Actual result: 3. The status column still shows the 'in progress' icon even though we're waiting for user input

Additional information:
We should simply check for the 'btn-action-required' class in the row - it's a currently a button, not a link, hence why the test is failing.

https://github.com/openstack/horizon/blob/362e0a7373/horizon/static/horizon/js/horizon.tables.js#L59

Julie Pichon (jpichon)
description: updated
description: updated
Floren (florenllanos)
Changed in horizon:
status: New → Confirmed
Thai Tran (tqtran)
Changed in horizon:
assignee: nobody → Thai Tran (tqtran)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/74914

Changed in horizon:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/74914
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=6214752fa4dae01582cccb2f77eafd4cfd0aeb6a
Submitter: Jenkins
Branch: master

commit 6214752fa4dae01582cccb2f77eafd4cfd0aeb6a
Author: Thai Tran <email address hidden>
Date: Wed Feb 19 19:15:32 2014 -0800

    Action required status shows proper icon

    Today, when user resize an instance and is waiting to confirm the
    action, the status column shows a loading icon.

    This fix will change it so that the status column will instead show a
    action_required icon.

    Change-Id: I887a270b2b64729447e5470d0d49366a6931d0f5
    Closes-Bug: #1279878

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
milestone: none → icehouse-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: icehouse-3 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.