Deleting enabled domain results in confusing error

Bug #1279823 reported by Steven Hardy
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Low
Steven Hardy

Bug Description

# openstack --os-token foobar --os-url=http://127.0.0.1:5000/v3 --os-identity-api-version=3 domain create heat
+---------+---------------------------------------------------------------------------------------+
| Field | Value |
+---------+---------------------------------------------------------------------------------------+
| enabled | True |
| id | b1816241c3bd4a67b4059dcf62526e31 |
| links | {u'self': u'http://192.168.122.214:5000/v3/domains/b1816241c3bd4a67b4059dcf62526e31'} |
| name | heat |
+---------+---------------------------------------------------------------------------------------+

# openstack --os-token foobar --os-url=http://127.0.0.1:5000/v3 --os-identity-api-version=3 domain delete heat
ERROR: cliff.app You are not authorized to perform the requested action, delete a domain that is not disabled. (HTTP 403)

This, to me at least, is confusing - from a user perspective, it sounds like an instruction to delete a domain that is not disabled (i.e one which is enabled, which it is!), rather than information that you can only delete a domain which is not *enabled*

Rewording this slightly would make the user-visible error clearer IMO:

# openstack --os-token foobar --os-url=http://127.0.0.1:5000/v3 --os-identity-api-version=3 domain delete heat
ERROR: cliff.app You are not authorized to perform the requested action, can't delete a domain that is enabled. (HTTP 403)

Steven Hardy (shardy)
Changed in keystone:
assignee: nobody → Steven Hardy (shardy)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/73299

Changed in keystone:
status: New → In Progress
Dolph Mathews (dolph)
Changed in keystone:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/73299
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=1878300dacfd25b02563a5cef5c473fbed4861f2
Submitter: Jenkins
Branch: master

commit 1878300dacfd25b02563a5cef5c473fbed4861f2
Author: Steven Hardy <email address hidden>
Date: Thu Feb 13 14:23:31 2014 +0000

    Provide clearer error when deleting enabled domain

    Currently the message is confusing, because it reads like an instruction
    to delete an enabled domain, rather than an instruction that you can
    only delete disabled domains. Hopefully this wording is a little clearer
    for users.

    Change-Id: I5189cd1bbae0e485d03660be19f20879110a3b3e
    Closes-Bug: #1279823

Changed in keystone:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in keystone:
milestone: none → icehouse-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: icehouse-3 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.