Improvement: Mock handlers in controller tests

Bug #1279775 reported by Julien Vey
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Solum
Fix Released
Low
Pierre Padrixe (stannie)

Bug Description

Currently, controllers tests in solum/tests/api/v1 don't mock the handler part.
Now that we have specific tests for handlers, this part should be mock.

Some patches with such tests are currently in review. We should wait for those patches to be merged before refactoring controller tests.

This bug is here to track the work we have to do and not forget it

Tags: improvements
Julien Vey (vey-julien)
summary: - Mock jandlers in controllers tests
+ Mock handlers in controllers tests
Julien Vey (vey-julien)
Changed in solum:
importance: Undecided → Wishlist
Adrian Otto (aotto)
summary: - Mock handlers in controllers tests
+ Improvement: Mock handlers in controller tests
Changed in solum:
importance: Wishlist → Low
milestone: none → 2014.1.2
status: New → Triaged
Changed in solum:
assignee: nobody → Pierre Padrixe (stannie) (pierre-padrixe)
Changed in solum:
status: Triaged → In Progress
Adrian Otto (aotto)
tags: added: improvements
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to solum (master)

Reviewed: https://review.openstack.org/90734
Committed: https://git.openstack.org/cgit/stackforge/solum/commit/?id=2afbbf01f1c43dc06a116ad3396abb285815d751
Submitter: Jenkins
Branch: master

commit 2afbbf01f1c43dc06a116ad3396abb285815d751
Author: Pierre Padrixe <email address hidden>
Date: Mon Apr 28 15:15:55 2014 +0200

    Add missing handler mocks in Controllers test

    Also replaced get_all handler mocks return_value from empty array
    to list of FakeObjects

    Closes-Bug: #1279775
    Change-Id: Ib9fcea7430ae2b73e02dc193b348d6960ca63841

Changed in solum:
status: In Progress → Fix Committed
Adrian Otto (aotto)
Changed in solum:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.