Improvement: Mock handlers in controller tests
Bug #1279775 reported by
Julien Vey
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Solum |
Fix Released
|
Low
|
Pierre Padrixe (stannie) |
Bug Description
Currently, controllers tests in solum/tests/api/v1 don't mock the handler part.
Now that we have specific tests for handlers, this part should be mock.
Some patches with such tests are currently in review. We should wait for those patches to be merged before refactoring controller tests.
This bug is here to track the work we have to do and not forget it
summary: |
- Mock jandlers in controllers tests + Mock handlers in controllers tests |
Changed in solum: | |
importance: | Undecided → Wishlist |
summary: |
- Mock handlers in controllers tests + Improvement: Mock handlers in controller tests |
Changed in solum: | |
importance: | Wishlist → Low |
milestone: | none → 2014.1.2 |
status: | New → Triaged |
Changed in solum: | |
assignee: | nobody → Pierre Padrixe (stannie) (pierre-padrixe) |
Changed in solum: | |
status: | Triaged → In Progress |
tags: | added: improvements |
Changed in solum: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Reviewed: https:/ /review. openstack. org/90734 /git.openstack. org/cgit/ stackforge/ solum/commit/ ?id=2afbbf01f1c 43dc06a116ad339 6abb285815d751
Committed: https:/
Submitter: Jenkins
Branch: master
commit 2afbbf01f1c43dc 06a116ad3396abb 285815d751
Author: Pierre Padrixe <email address hidden>
Date: Mon Apr 28 15:15:55 2014 +0200
Add missing handler mocks in Controllers test
Also replaced get_all handler mocks return_value from empty array
to list of FakeObjects
Closes-Bug: #1279775 73e02dc193b348d 6960ca63841
Change-Id: Ib9fcea7430ae2b