CONF should not be read before ironic/common/service.prepare_service() call

[Max Lobur]

Oslo config parses it's values from config when https://github.com/openstack/ironic/blob/master/ironic/common/service.py#L65 executed. It's called from prepare_service method of out services. So there are a few places where config read during parse time (before prepare_service) and therefore the options does not correspond to /etc/ironic/ironic.conf values, instead they always have defaults.

REST API service:
1. Config read
https://github.com/openstack/ironic/blob/master/ironic/api/config.py#L40
2. prepare_service (actual config parsing)
https://github.com/openstack/ironic/blob/master/ironic/cmd/api.py#L38

Conductor service:
1. Config read
https://github.com/openstack/ironic/blob/master/ironic/common/hash_ring.py#L49
https://github.com/openstack/ironic/blob/master/ironic/conductor/manager.py#L367
https://github.com/openstack/ironic/blob/master/ironic/conductor/manager.py#L372
2. prepare_service (actual config parsing)
https://github.com/openstack/ironic/blob/master/ironic/cmd/conductor.py#L39

I tested all these places with pdb and for each of them prepare_service follows the config read.

[Haomeng,Wang (whaom)]

A reference "Why does oslo.config have a CONF object? Global object SUCK!"

https://wiki.openstack.org/wiki/Oslo#Why_does_oslo.config_have_a_CONF_object.3F_Global_object_SUCK.21

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/75883

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/75883
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=45ce0adb0719c8fd76ff3a415f8bac02c294f2e5
Submitter: Jenkins
Branch: master

commit 45ce0adb0719c8fd76ff3a415f8bac02c294f2e5
Author: Lucas Alvares Gomes <email address hidden>
Date: Mon Feb 24 14:27:18 2014 +0000

    Do not use CONF as a default parameter value

    In the HashRing.__init__() the "replicas" parameter defaults to
    CONF.hash_distribution_replicas, the problem with this approach is
    that Ironic might not have loaded the configuration at the time this
    configuration is evaluated in the function definition. This patch fix
    the problem by using a placeholder value instead of the configuration
    option in the function definition.

    Partial-Bug: #1279774
    Change-Id: I5d8d7cd18a8a6b050f3aa448a337e0156e67ced5

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/77176

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/80300

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/81524

[aeva black (tenbrae)]

Bug should be closed once https://review.openstack.org/#/c/81524/ lands.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/81524
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=93b042c0be12f0530996f667e3a58543e952be74
Submitter: Jenkins
Branch: master

commit 93b042c0be12f0530996f667e3a58543e952be74
Author: Yuriy Zveryanskyy <email address hidden>
Date: Wed Mar 19 15:18:27 2014 +0200

    Fix 'spacing' parameters for periodic tasks

    conductor.manager module contains 'spacing' parameters for periodic
    tasks, they do not work because manager module imported before
    parsing config options.
    There is not such problem in Nova which uses create() method in class
    derived from common Service for lazy loading manager module.
    Because this derived class not needed for Ironic simple load_manager
    function added to common.service.

    Partial-Bug: #1279774
    Change-Id: Ib31024c8eaf75d38de09983459d86125847cdf30