R18rc1 FTBFS Debian GNU/kFreeBSD

Bug #1279679 reported by Teppo Mäenpää
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Fix Released
Low
Unassigned

Bug Description

CMakefile misidentifies Debian on kFreeBSD as FreeBSD, attempts to import some FreeBSD specific libraries and then fails.

Revision history for this message
Teppo Mäenpää (kxq) wrote :

While reading the bug #1279029 report, I got curious how changing a kernel makes Widelands not compile; we are mostly using libraries, which should mind the difference.

The reason was that Widelands makefile assumes that the OS is a FreeBSD, if a match is found from the system name. Now, Debian running over FreeBSD kernel identifies itself as Debian GNU/kFreeBSD (regexp match, seemingly also match in the way cmake matches things), while it still should be treated like a "Linux-like OS" in this context.

Revision history for this message
Teppo Mäenpää (kxq) wrote :

I had forgotten a dummy extra printf to the previous file. This file contains only the relevant changes.

tags: added: bsd cmake ftbfs patch
Changed in widelands:
status: New → Confirmed
SirVer (sirver)
Changed in widelands:
importance: Undecided → Low
milestone: none → build19-rc1
status: Confirmed → In Progress
Revision history for this message
Teppo Mäenpää (kxq) wrote :

I could merge the patch to trunk, if it looks safe from your point of view. If you prefer, I can make a branch of it and request q review.

Revision history for this message
SirVer (sirver) wrote :

Feel free to merge - the patch should not hurt, but it is also not ideal. The perfect solution would be to get rid of usages of MAX_PATH and replace them with std::string everywhere.

Teppo Mäenpää (kxq)
Changed in widelands:
status: In Progress → Fix Committed
GunChleoc (gunchleoc)
tags: added: buildsystem
removed: cmake
GunChleoc (gunchleoc)
Changed in widelands:
status: Fix Committed → Fix Released
Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in build19-rc1.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.